Re: [PATCH] More typofixes.

2013-07-29 Thread Junio C Hamano
Marc Branchaud writes: > On 13-07-29 01:52 PM, Junio C Hamano wrote: >> Here is what I salvaged for 'maint'. Eyeballing by others is very >> much appreciated. >> >> -- >8 -- >> From: Ondřej Bílka >> Subject: [PATCH] many small typofixes >> Date: Mon, 29 Jul 2013 10:18:21 +0200 >> >> Signed-of

Re: [PATCH] More typofixes.

2013-07-29 Thread Marc Branchaud
On 13-07-29 01:52 PM, Junio C Hamano wrote: > Here is what I salvaged for 'maint'. Eyeballing by others is very > much appreciated. > > -- >8 -- > From: Ondřej Bílka > Subject: [PATCH] many small typofixes > Date: Mon, 29 Jul 2013 10:18:21 +0200 > > Signed-off-by: Ondřej Bílka > Signed-off-by:

Re: [PATCH] More typofixes.

2013-07-29 Thread Stefan Beller
On 07/29/2013 07:52 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Marc Branchaud writes: >> >>> Unfortunately no automated system is perfect (see some of my comments >>> below). >>> I'm all for an automated system that identifies potential misspellings, but >>> I'm wary of anything t

Re: [PATCH] More typofixes.

2013-07-29 Thread Junio C Hamano
Junio C Hamano writes: > Marc Branchaud writes: > >> Unfortunately no automated system is perfect (see some of my comments below). >> I'm all for an automated system that identifies potential misspellings, but >> I'm wary of anything that attempts to automatically correct perceived errors, >> o

Re: [PATCH] More typofixes.

2013-07-29 Thread Junio C Hamano
Marc Branchaud writes: > Unfortunately no automated system is perfect (see some of my comments below). > I'm all for an automated system that identifies potential misspellings, but > I'm wary of anything that attempts to automatically correct perceived errors, > or that can't be overruled. In t

Re: [PATCH] More typofixes.

2013-07-29 Thread Ondřej Bílka
On Mon, Jul 29, 2013 at 10:55:41AM -0400, Marc Branchaud wrote: > On 13-07-29 04:18 AM, Ondřej Bílka wrote: > > Hi, > > > > I improved my tool and it catched following additional typos. > > > > As with any big project best way to catch errors is to have automated > > checks that catch them ( Othe

Re: [PATCH] More typofixes.

2013-07-29 Thread Marc Branchaud
On 13-07-29 04:18 AM, Ondřej Bílka wrote: > Hi, > > I improved my tool and it catched following additional typos. > > As with any big project best way to catch errors is to have automated > checks that catch them ( Other possibility would be to read everything ten > times to get error rate down b

Re: [PATCH] More typofixes.

2013-07-29 Thread Ramkumar Ramachandra
Ondřej Bílka wrote: > diff --git a/builtin/log.c b/builtin/log.c > index 2625f98..01b49b3 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -304,7 +304,7 @@ static void setup_early_output(struct rev_info *rev) > * tenth of a second, don't even bother doing the > * early-outp

Re: [PATCH] More typofixes.

2013-07-29 Thread David Aguilar
On Mon, Jul 29, 2013 at 1:18 AM, Ondřej Bílka wrote: > Hi, > > I improved my tool and it catched following additional typos. > > As with any big project best way to catch errors is to have automated > checks that catch them ( Other possibility would be to read everything ten > times to get error r

Re: [PATCH] More typofixes.

2013-07-29 Thread Bryan Turner
> diff --git a/pathspec.c b/pathspec.c > index 6ea0867..27ffe77 100644 > --- a/pathspec.c > +++ b/pathspec.c > @@ -40,7 +40,7 @@ void add_pathspec_matches_against_index(const char > **pathspec, > /* > * Finds which of the given pathspecs match items in the index. > * > - * This is a one-shot