Re: [PATCH] add a reflog_exists and delete_reflog abstraction

2014-05-07 Thread Ronnie Sahlberg
On Tue, May 6, 2014 at 8:23 AM, Michael Haggerty wrote: > On 05/06/2014 12:57 AM, Ronnie Sahlberg wrote: >> This is a single patch that adds two new functions to try to hide the reflog >> implementation details from the callers in checkout.c and reflog.c. >> It adds new functions to test if a refl

Re: [PATCH] add a reflog_exists and delete_reflog abstraction

2014-05-06 Thread Ronnie Sahlberg
On Tue, May 6, 2014 at 12:15 PM, Junio C Hamano wrote: > Ronnie Sahlberg writes: > >> It currently has a hard assumption that the loose ref file must exist at this >> stage or else it would end up deleting the reflog which is true today, as far >> as I can tell, but would break if git would chang

Re: [PATCH] add a reflog_exists and delete_reflog abstraction

2014-05-06 Thread Junio C Hamano
Ronnie Sahlberg writes: > It currently has a hard assumption that the loose ref file must exist at this > stage or else it would end up deleting the reflog which is true today, as far > as I can tell, but would break if git would change such that we could have > a branch checked out without havin

Re: [PATCH] add a reflog_exists and delete_reflog abstraction

2014-05-06 Thread Michael Haggerty
On 05/06/2014 12:57 AM, Ronnie Sahlberg wrote: > This is a single patch that adds two new functions to try to hide the reflog > implementation details from the callers in checkout.c and reflog.c. > It adds new functions to test if a reflog exists and to delete it, thus > allowing checkout.c to perf