Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-03 Thread Jens Lindström
On Wed, Jul 3, 2013 at 7:26 PM, Junio C Hamano wrote: > Jens Lindström writes: > >> Not always. The Linux kernel can at least be configured not to allow >> it. It seems this is enabled by default in at least Debian. > > You learn a new thing every day, I guess. I am on Debian, I do not > think

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-03 Thread Junio C Hamano
Jens Lindström writes: > On Mon, Jul 1, 2013 at 6:20 PM, Junio C Hamano wrote: >> I am not sure if we should care that deeply about them in the first >> place. > > Fine by me; I don't really have a strong opinion on the matter. > >> Besides, I think you can make a hardlink to a file that you can

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-03 Thread Jens Lindström
On Mon, Jul 1, 2013 at 6:20 PM, Junio C Hamano wrote: > I am not sure if we should care that deeply about them in the first > place. Fine by me; I don't really have a strong opinion on the matter. > Besides, I think you can make a hardlink to a file that you cannot > read. Not always. The Linu

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-01 Thread Junio C Hamano
Jens Lindström writes: > On Fri, Jun 28, 2013 at 8:38 PM, Junio C Hamano wrote: > >>> The pack-*.keep files are temporary, and serve no purpose in the >>> clone. >> >> They are not temporary, actually. A user can deliberatey create a >> "keep" marker after packing with a good set of parameters,

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-07-01 Thread Jens Lindström
On Fri, Jun 28, 2013 at 8:38 PM, Junio C Hamano wrote: >> The pack-*.keep files are temporary, and serve no purpose in the >> clone. > > They are not temporary, actually. A user can deliberatey create a > "keep" marker after packing with a good set of parameters, so that > the resulting pack will

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-06-28 Thread Junio C Hamano
Junio C Hamano writes: > I am perfectly fine with a change that allows a local clone to skip > and not error out when such a "keep" marker cannot be copied, I do > not know if it is a good idea to unconditionally skip and not even > attempt to copy it. That is, something like this, perhaps? We

Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

2013-06-28 Thread Junio C Hamano
Jens Lindstrom writes: Hmph. I am of two minds here. > The pack-*.keep files are temporary, and serve no purpose in the > clone. They are not temporary, actually. A user can deliberatey create a "keep" marker after packing with a good set of parameters, so that the resulting pack will be kept