Re: [PATCH] completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaround

2013-06-10 Thread Junio C Hamano
SZEDER Gábor writes: > Anyway. Although the completion script in Fedora's gvfs package might > be fixed, there are other completion scripts making the same mistake, > so I'm afraid we should keep the workaround and drop this patch. > Moreover, we should even consider extending our workaround by

Re: [PATCH] completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaround

2013-06-10 Thread SZEDER Gábor
First things first: Junio, please don't pick up this patch. On Sun, Jun 09, 2013 at 05:09:54PM -0700, Jonathan Nieder wrote: > SZEDER Gábor wrote: > > > Fedore 9 shipped the gvfs package with a buggy Bash completion script: > > it removed the ':' character from COMP_WORDBREAKS, thereby breaking

Re: [PATCH] completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaround

2013-06-09 Thread Eric Sunshine
On Sun, Jun 9, 2013 at 7:59 PM, SZEDER Gábor wrote: > Fedore 9 shipped the gvfs package with a buggy Bash completion script: s/Fedore/Fedora/ > it removed the ':' character from COMP_WORDBREAKS, thereby breaking > certain features of git's completion script. We worked this around in > db8a9ff0

Re: [PATCH] completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaround

2013-06-09 Thread Jonathan Nieder
SZEDER Gábor wrote: > Fedore 9 shipped the gvfs package with a buggy Bash completion script: > it removed the ':' character from COMP_WORDBREAKS, thereby breaking > certain features of git's completion script. We worked this around in > db8a9ff0 (bash completion: Resolve git show ref:path losing