On Wed, Oct 24, 2012 at 11:08:26PM +0200, Krzysztof Mazur wrote:
ok, I'm sending a version that just adds quote_subject() without
changing any logic, so now we still have in first case:
/[^[:ascii:]]/
and in the latter case:
!is_rfc2047_quoted($subject) /^[:ascii:]]/
In the
On Thu, Oct 25, 2012 at 05:01:49AM -0400, Jeff King wrote:
- if ($broken_encoding{$t} !is_rfc2047_quoted($subject)
- ($subject =~ /[^[:ascii:]]/)) {
- $subject = quote_rfc2047($subject, $auto_8bit_encoding);
+ if ($broken_encoding{$t}
On Thu, Oct 25, 2012 at 05:01:49AM -0400, Jeff King wrote:
Hmm. What is this patch on top of? It looks like it is on top of your
original patch, but when I tried it on top of that, it does not apply
either, and the index lines in the patch do not mention a sha1 that I do
not have.
Sorry,
On Thu, Oct 25, 2012 at 01:19:19PM +0200, Krzysztof Mazur wrote:
On Thu, Oct 25, 2012 at 06:08:54AM -0400, Jeff King wrote:
Ah, never mind. I missed your earlier use compose-encoding for
Subject. I've queued it and all of the follow-ons onto the
km/send-email-compose-encoding topic.
On Thu, Oct 25, 2012 at 06:08:54AM -0400, Jeff King wrote:
Ah, never mind. I missed your earlier use compose-encoding for
Subject. I've queued it and all of the follow-ons onto the
km/send-email-compose-encoding topic.
thanks, what about the problem with whitespaces in quote_subject patch?
On Wed, Oct 24, 2012 at 10:03:35AM +0200, Krzysztof Mazur wrote:
The git-send-email always use RFC2047 subject quoting for files
with broken encoding - non-ASCII files without Content-Transfer-Encoding,
even for ASCII subjects. Now for ASCII subjects the RFC2047 quoting will be
skipped.
On Wed, Oct 24, 2012 at 04:46:36AM -0400, Jeff King wrote:
On Wed, Oct 24, 2012 at 10:03:35AM +0200, Krzysztof Mazur wrote:
The git-send-email always use RFC2047 subject quoting for files
with broken encoding - non-ASCII files without Content-Transfer-Encoding,
even for ASCII subjects.
On Wed, Oct 24, 2012 at 07:10:36PM +0200, Krzysztof Mazur wrote:
- if ($broken_encoding{$t} !is_rfc2047_quoted($subject)) {
+ if ($broken_encoding{$t} !is_rfc2047_quoted($subject)
+ ($subject =~ /[^[:ascii:]]/)) {
Is that test sufficient? We would also need to
On Wed, Oct 24, 2012 at 03:25:30PM -0400, Jeff King wrote:
Right, but I was specifically worried about raw =?, which is only an
issue due to rfc2047 itself.
However, reading the patch again, we are already checking for that with
is_rfc2047_quoted. It might miss the case where we have =? but
9 matches
Mail list logo
