Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Felipe Contreras
On Sat, Jun 1, 2013 at 9:03 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Nobody is checking for specific error codes; it's the errno that's important. Have you just disregarded the in-code comment you just removed

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Duy Nguyen
On Sat, Jun 1, 2013 at 9:06 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Jun 1, 2013 at 9:03 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Nobody is checking for specific error codes; it's the errno

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Thomas Rast
Felipe Contreras felipe.contre...@gmail.com writes: Nobody is checking for specific error codes; it's the errno that's important. [...] - /* - * This return value is chosen so that code 0xff - * mimics the exit code that a POSIX shell would report for

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Felipe Contreras
On Sat, Jun 1, 2013 at 9:08 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 9:06 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Jun 1, 2013 at 9:03 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Felipe Contreras
On Sat, Jun 1, 2013 at 9:19 AM, Thomas Rast tr...@inf.ethz.ch wrote: Felipe Contreras felipe.contre...@gmail.com writes: Nobody is checking for specific error codes; it's the errno that's important. [...] - /* - * This return value is chosen so that code 0xff -

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Felipe Contreras
On Sat, Jun 1, 2013 at 9:21 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Nobody is checking for specific error codes; it's the errno that's important. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com ---

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Duy Nguyen
On Sat, Jun 1, 2013 at 9:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Jun 1, 2013 at 9:21 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Yeah, and last year we returned a different code. The world

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Felipe Contreras
On Sat, Jun 1, 2013 at 9:36 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 9:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Jun 1, 2013 at 9:21 AM, Duy Nguyen pclo...@gmail.com wrote: On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Jeff King
On Sat, Jun 01, 2013 at 09:30:50AM -0500, Felipe Contreras wrote: The original commit that introduces this says run_command: encode deadly signal number in the return value We now write the signal number in the error message if the program terminated by a signal. The

Re: [PATCH] run-command: simplify wait_or_whine

2013-06-01 Thread Felipe Contreras
On Sat, Jun 1, 2013 at 12:01 PM, Jeff King p...@peff.net wrote: On Sat, Jun 01, 2013 at 09:30:50AM -0500, Felipe Contreras wrote: commit 709ca730f8e093005cc882bfb86c0ca9c83d345b Author: Jeff King p...@peff.net Date: Sat Jan 5 09:49:49 2013 -0500 run-command: encode signal death as a