Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-27 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> This change could introduce a regression for people on a platform >> whose certificate directory is /etc/ssl/certs but its IO::Socket:SSL >> somehow fails to use it as SSL_ca_path without being told. > > I can confirm that my git-send-email

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-26 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > This change could introduce a regression for people on a platform > whose certificate directory is /etc/ssl/certs but its IO::Socket:SSL > somehow fails to use it as SSL_ca_path without being told. I can confirm that my git-send-email doesn't regress to the pre-35035bbf sta

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-17 Thread Kyle J. McKay
On Jan 17, 2014, at 10:14, Junio C Hamano wrote: If I am reading the code correctly, if /etc/ssl/certs does not exist on the filesystem at all, it wouldn't even attempt verification, so I take your "the verification will fail" to mean that you forgot to also mention "And on OS X, /etc/ssl/certs d

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-17 Thread Junio C Hamano
"Kyle J. McKay" writes: > On my OS X platform depending on which version of OpenSSL I'm using, > the OPENSSLDIR path would be one of these: > > /System/Library/OpenSSL > /opt/local/etc/openssl > > And neither of those uses a "certs" directory, they both use a > "cert.pem" bundle instead: > >

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-16 Thread Kyle J. McKay
On Jan 16, 2014, at 15:19, Junio C Hamano wrote: Jonathan Nieder writes: FWIW this should help on Mac OS X, too. Folks using git on mac at $DAYJOB have been using the workaround described at http://mercurial.selenic.com/wiki/CACertificates#Mac_OS_X_10.6_and_higher so I forgot to report it. :/

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-16 Thread Junio C Hamano
Jonathan Nieder writes: > FWIW this should help on Mac OS X, too. Folks using git on mac > at $DAYJOB have been using the workaround described at > http://mercurial.selenic.com/wiki/CACertificates#Mac_OS_X_10.6_and_higher > so I forgot to report it. :/ Hmph, is that the same issue, though? Tha

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-15 Thread Ruben Kerkhof
On 15 jan. 2014, at 22:30, Junio C Hamano wrote: > Ruben Kerkhof writes: > >>> ... because? Is it because the cert_path on your platform is >>> different from /etc/ssl/certs? What platform was this anyway? >> >> This is Fedora rawhide, git-1.8.5.2-1.fc21.x86_64, >> perl-IO-Socket-SSL-1.962

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-15 Thread Jonathan Nieder
Junio C Hamano wrote: > Ruben Kerkhof writes: >> As a last check, I set smtpsslcertpath = /etc/pki/tls/cert.pem in >> ~/.gitconfig and git-send-email works fine now. > > Which would mean that the existing code, by blindly defaulting to > /etc/ssl/certs/ and misdiagnosing that the directory is mea

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-15 Thread Junio C Hamano
Ruben Kerkhof writes: >> ... because? Is it because the cert_path on your platform is >> different from /etc/ssl/certs? What platform was this anyway? > > This is Fedora rawhide, git-1.8.5.2-1.fc21.x86_64, > perl-IO-Socket-SSL-1.962-1.fc21.noarch >> >> I see in the original discussion in your

Re: [PATCH] send-email: If the ca path is not specified, use the defaults

2014-01-15 Thread Junio C Hamano
Igor Gnatenko writes: > From: Ruben Kerkhof > > I use gmail for sending patches. > If I have the following defined in my ~/.gitconfig: > [sendemail] > smtpencryption = tls > smtpserver = smtp.gmail.com > smtpuser = ru...@rubenkerkhof.com > smtpserverport = 587 > > and try