Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-20 Thread Marc Khouzam
On Sat, Nov 17, 2012 at 1:01 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I gather that using a wrapper for zsh causes concerns about backwards-compatibility. I don't see any concerns. if [[ -n ${ZSH_VERSION-} ]]; then # replace below by zsh completion commands calling `bash

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-20 Thread Junio C Hamano
Marc Khouzam marc.khou...@gmail.com writes: This one is already merged to 'next'. Awesome! I didn't notice. If I want to suggest an improvement (like checking if the bash script is available), do I just post a patch here? Yes, as a follow-up patch (or two). Thanks. -- To unsubscribe from

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-17 Thread SZEDER Gábor
On Fri, Nov 16, 2012 at 10:46:16PM +0100, Felipe Contreras wrote: On Fri, Nov 16, 2012 at 10:22 PM, SZEDER Gábor sze...@ira.uka.de wrote: On Fri, Nov 16, 2012 at 10:03:41PM +0100, Felipe Contreras wrote: As I understand the main issues with using the completion script with zsh are the

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-17 Thread Felipe Contreras
On Sat, Nov 17, 2012 at 11:56 AM, SZEDER Gábor sze...@ira.uka.de wrote: On Fri, Nov 16, 2012 at 10:46:16PM +0100, Felipe Contreras wrote: But even in that case, if push comes to shoves, this zsh wrapper can ultimately read COMPREPLY and figure things backwards, as even more previous versions

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-17 Thread SZEDER Gábor
On Sat, Nov 17, 2012 at 12:46:27PM +0100, Felipe Contreras wrote: On Sat, Nov 17, 2012 at 11:56 AM, SZEDER Gábor sze...@ira.uka.de wrote: On Fri, Nov 16, 2012 at 10:46:16PM +0100, Felipe Contreras wrote: But even in that case, if push comes to shoves, this zsh wrapper can ultimately read

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-17 Thread Marc Khouzam
On Fri, Nov 16, 2012 at 4:56 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:20 PM, Junio C Hamano gits...@pobox.com wrote: The point is not about the quality of zsh's emulation of (k)sh when it is run under that mode, but is about not having to have that

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-17 Thread Felipe Contreras
On Sat, Nov 17, 2012 at 6:15 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Fri, Nov 16, 2012 at 4:56 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:20 PM, Junio C Hamano gits...@pobox.com wrote: The point is not about the quality of zsh's emulation of

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam marc.khou...@gmail.com wrote: The current tcsh-completion support for Git, as can be found on the Internet, takes the approach of defining the possible completions

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 3:39 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam marc.khou...@gmail.com wrote: The current tcsh-completion support for Git, as can be

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 3:39 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 4:48 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Is it possible to just check if this is a login shell? I think it would be nice to allow the user to manually source

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Marc Khouzam
On Fri, Nov 16, 2012 at 12:18 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 4:48 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Is it possible to just check if this is a login

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 7:20 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Fri, Nov 16, 2012 at 12:18 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Nov 16, 2012 at 4:48 PM, Marc Khouzam marc.khou...@gmail.com wrote: On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread SZEDER Gábor
On Fri, Nov 16, 2012 at 09:04:06PM +0100, Felipe Contreras wrote: I agree, and this is why I made the proposed __git_complete_with_output () generic. That way it could be used by other shells or programs. But at this time, only tcsh would make use of it. If you think having

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 9:40 PM, SZEDER Gábor sze...@ira.uka.de wrote: On Fri, Nov 16, 2012 at 09:04:06PM +0100, Felipe Contreras wrote: I agree, and this is why I made the proposed __git_complete_with_output () generic. That way it could be used by other shells or programs. But at this

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Junio C Hamano
SZEDER Gábor sze...@ira.uka.de writes: For zsh, perhaps? Yeah, I was wondering about that. If we make zsh completion read output from a little stub in bash completion, just like Felipe steered this series for tcsh, we do not have to worry about zsh does not split words unless emulating a shell

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread SZEDER Gábor
On Fri, Nov 16, 2012 at 10:03:41PM +0100, Felipe Contreras wrote: On Fri, Nov 16, 2012 at 9:40 PM, SZEDER Gábor sze...@ira.uka.de wrote: On Fri, Nov 16, 2012 at 09:04:06PM +0100, Felipe Contreras wrote: I agree, and this is why I made the proposed __git_complete_with_output () generic.

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 10:22 PM, SZEDER Gábor sze...@ira.uka.de wrote: On Fri, Nov 16, 2012 at 10:03:41PM +0100, Felipe Contreras wrote: As I understand the main issues with using the completion script with zsh are the various little incompatibilities between the two shells and bugs in

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-16 Thread Felipe Contreras
On Fri, Nov 16, 2012 at 10:20 PM, Junio C Hamano gits...@pobox.com wrote: SZEDER Gábor sze...@ira.uka.de writes: For zsh, perhaps? Yeah, I was wondering about that. If we make zsh completion read output from a little stub in bash completion, just like Felipe steered this series for tcsh,

Re: [PATCH] tcsh-completion re-using git-completion.bash

2012-11-15 Thread Felipe Contreras
On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam marc.khou...@gmail.com wrote: The current tcsh-completion support for Git, as can be found on the Internet, takes the approach of defining the possible completions explicitly. This has the obvious draw-back to require constant updating as the Git