Re: [PATCH] tests: Introduce test_seq

2012-08-04 Thread Michał Kiedrowicz
Junio C Hamano gits...@pobox.com wrote: Tentatively I'll queue this one on top, but I am tempted to squash this in before merging the topic down. -- 8 -- Subject: [PATCH] fixup! tests: Introduce test_seq Complex chains of and || are harder to read when used as replacement for if/else

Re: [PATCH] tests: Introduce test_seq

2012-08-04 Thread Junio C Hamano
Johannes Sixt j...@kdbg.org writes: And the reason for this is that we always told people don't use seq and they submitted an updated patch. What would we have to do now? We have to tell them don't use seq, use test_seq. Therefore, the patch does not accomplish anything useful, IMO. The

Re: [PATCH] tests: Introduce test_seq

2012-08-03 Thread Jeff King
On Fri, Aug 03, 2012 at 09:57:15PM +0200, Michał Kiedrowicz wrote: Jeff King wrote: The seq command is GNU-ism, and is missing at least in older BSD releases and their derivatives, not to mention antique commercial Unixes. We already purged it in b3431bc (Don't

Re: [PATCH] tests: Introduce test_seq

2012-08-03 Thread Jeff King
On Fri, Aug 03, 2012 at 10:04:50PM +0200, Michał Kiedrowicz wrote: Previous patch didn't support `test_seq 1 50` (I removed it accidentally). Our emails just crossed paths. :) +# test_seq is a portable replacement for seq(1). +# It may be used like: +# +#for i in `test_seq 100`; do +#

Re: [PATCH] tests: Introduce test_seq

2012-08-03 Thread Michał Kiedrowicz
Jeff King p...@peff.net wrote: On Fri, Aug 03, 2012 at 10:04:50PM +0200, Michał Kiedrowicz wrote: Previous patch didn't support `test_seq 1 50` (I removed it accidentally). Our emails just crossed paths. :) Yeah :) +# test_seq is a portable replacement for seq(1). +# It may be

Re: [PATCH] tests: Introduce test_seq

2012-08-03 Thread Michał Kiedrowicz
Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: On Fri, Aug 03, 2012 at 09:57:15PM +0200, Michał Kiedrowicz wrote: Jeff King wrote: The seq command is GNU-ism, and is missing at least in older BSD releases and their derivatives, not to mention antique

Re: [PATCH] tests: Introduce test_seq

2012-08-03 Thread Jeff King
On Fri, Aug 03, 2012 at 03:48:19PM -0700, Junio C Hamano wrote: Michał Kiedrowicz michal.kiedrow...@gmail.com writes: Jeff King wrote: The seq command is GNU-ism, and is missing at least in older BSD releases and their derivatives, not to mention antique commercial

Re: [PATCH] tests: Introduce test_seq

2012-08-03 Thread Junio C Hamano
Tentatively I'll queue this one on top, but I am tempted to squash this in before merging the topic down. -- 8 -- Subject: [PATCH] fixup! tests: Introduce test_seq Complex chains of and || are harder to read when used as replacement for if/else statements, but it is easy to rewrite it with a