Re: [msysGit] Re: [PATCH 0/7] Second part of msysgit/unicode
Am 18.06.2014 19:33, schrieb Junio C Hamano: > In the meantime, are Windows folks happy with the four topics queued > on 'pu' so far? I would like to start moving them down to 'next' > and to 'master' soonish. > > They consist of these individual patches: > > $ git shortlog ^master \ > sk/mingw-dirent \ > sk/mingw-main \ > sk/mingw-uni-console \ > sk/mingw-unicode-spawn-args Topic sk/test-cmp-bin revealed a new breakage in t5000-tar-tree, specifically, the penultimate test "remote tar.gz is allowed by default". I have yet to find out what it is (I suspect a LF-CRLF conversion issue) and whether it is in connection with one of these topics. I haven't had a chance to test the topics in the field. In particular, I have a few files with Shift-JIS content (but ASCII file names), and I would like to see how well I fare with the unicode topics in this situation. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] Second part of msysgit/unicode
Stepan Kasal writes: > Hello Karsten, > > On Tue, Jun 17, 2014 at 11:06:52AM +0200, Karsten Blees wrote: >> Am 11.06.2014 11:37, schrieb Stepan Kasal: >> > This is the second part of the time-proven unicode suport branch from >> > msysgit. >> > This batch is a collection of small independent changes, limited to >> > mingw.c. >> > The only exception is the last patch: it changes gitk and git-gui. >> >> I'm missing the other two "Unicode file name" patches (and "Win32: fix >> detection > > indeed. I noticed that after sending the plan quoted above. > Luckily, the gitk/git-gui patch was not accepted and has to be > resubmitted. > > So the plan for future submissions is: > > 1) two "Unicode file name" patches (with "fix... is_dir_empty" > squashed) > 2) the environament patches from your unicode branch (several > patches) > 3) "color term" (and env. var. TERM); updated according to your > instructions, thus sent separately after the series > 4) resubmit gitk / git-gui (have separate maintainers) > > This is work in progress, I suppose to mail 1) and 2) in a few days. > > Stepan In the meantime, are Windows folks happy with the four topics queued on 'pu' so far? I would like to start moving them down to 'next' and to 'master' soonish. They consist of these individual patches: $ git shortlog ^master \ sk/mingw-dirent \ sk/mingw-main \ sk/mingw-uni-console \ sk/mingw-unicode-spawn-args Johannes Schindelin (1): Win32: let mingw_execve() return an int Karsten Blees (18): Win32 dirent: remove unused dirent.d_ino member Win32 dirent: remove unused dirent.d_reclen member Win32 dirent: change FILENAME_MAX to MAX_PATH Win32 dirent: clarify #include directives Win32 dirent: improve dirent implementation Win32: move main macro to a function Win32: support Unicode console output Win32: detect console streams more reliably Win32: warn if the console font doesn't support Unicode Win32: add Unicode conversion functions Win32: Thread-safe windows console output Win32: fix broken pipe detection Win32: reliably detect console pipe handles Win32: simplify internal mingw_spawn* APIs Win32: fix potential multi-threading issue MinGW: disable CRT command line globbing Win32: Unicode arguments (outgoing) Win32: Unicode arguments (incoming) Stepan Kasal (1): mingw: avoid const warning Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] Second part of msysgit/unicode
Hello Karsten, On Tue, Jun 17, 2014 at 11:06:52AM +0200, Karsten Blees wrote: > Am 11.06.2014 11:37, schrieb Stepan Kasal: > > This is the second part of the time-proven unicode suport branch from > > msysgit. > > This batch is a collection of small independent changes, limited to mingw.c. > > The only exception is the last patch: it changes gitk and git-gui. > > I'm missing the other two "Unicode file name" patches (and "Win32: fix > detection indeed. I noticed that after sending the plan quoted above. Luckily, the gitk/git-gui patch was not accepted and has to be resubmitted. So the plan for future submissions is: 1) two "Unicode file name" patches (with "fix... is_dir_empty" squashed) 2) the environament patches from your unicode branch (several patches) 3) "color term" (and env. var. TERM); updated according to your instructions, thus sent separately after the series 4) resubmit gitk / git-gui (have separate maintainers) This is work in progress, I suppose to mail 1) and 2) in a few days. Stepan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] Second part of msysgit/unicode
Am 11.06.2014 11:37, schrieb Stepan Kasal: > This is the second part of the time-proven unicode suport branch from msysgit. > This batch is a collection of small independent changes, limited to mingw.c. > The only exception is the last patch: it changes gitk and git-gui. > I'm missing the other two "Unicode file name" patches (and "Win32: fix detection of empty directories in is_dir_empty", probably squashed). If gitk and git-gui expect file names to be UTF-8, git.exe should do so as well, don't you think? Otherwise OK (and AFAICT, there's only environment stuff left). > Win32: Unicode arguments (incoming) Note: This depends on "MSVC: link dynamically to the CRT", which was sent separately (and is already in master - good). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
