Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-05 Thread Jeff King
On Mon, May 05, 2014 at 02:30:12AM -0500, Felipe Contreras wrote: > If we have a) code that fixes a couple warnings with -O3 but introduces > hundreds with -O2, vs. b) code that has only a comple warnings with -O3, > I'd go for b) any day. I agree. But my point was to ask whether we can fix both.

Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-05 Thread Felipe Contreras
Jeff King wrote: > On Mon, May 05, 2014 at 01:14:43AM -0500, Felipe Contreras wrote: > > Jeff King wrote: > > > You could try reading the commit message of the commit you are > > > reverting, which explains it, but the short answer is: try compiling > > > with -O3. > > > > Sigh. And I'm the one w

Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-04 Thread Jeff King
On Mon, May 05, 2014 at 01:14:43AM -0500, Felipe Contreras wrote: > Jeff King wrote: > > On Mon, May 05, 2014 at 12:45:30AM -0500, Felipe Contreras wrote: > > > > > Jeff King wrote: > > > > On Sun, May 04, 2014 at 01:12:53AM -0500, Felipe Contreras wrote: > > > > > > > > > So it looks like gcc i

Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-04 Thread Felipe Contreras
Jeff King wrote: > On Mon, May 05, 2014 at 12:45:30AM -0500, Felipe Contreras wrote: > > > Jeff King wrote: > > > On Sun, May 04, 2014 at 01:12:53AM -0500, Felipe Contreras wrote: > > > > > > > So it looks like gcc is smarter now, and in trying to fix a few warnings > > > > we generated hundreds

Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-04 Thread Jeff King
On Mon, May 05, 2014 at 12:45:30AM -0500, Felipe Contreras wrote: > Jeff King wrote: > > On Sun, May 04, 2014 at 01:12:53AM -0500, Felipe Contreras wrote: > > > > > So it looks like gcc is smarter now, and in trying to fix a few warnings > > > we generated hundreds more. > > > > > > This reverts

Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-04 Thread Felipe Contreras
Jeff King wrote: > On Sun, May 04, 2014 at 01:12:53AM -0500, Felipe Contreras wrote: > > > So it looks like gcc is smarter now, and in trying to fix a few warnings > > we generated hundreds more. > > > > This reverts commit e208f9cc7574f5980faba498d0aa30b4defeb34f. > > And now we've gone the oth

Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"

2014-05-04 Thread Jeff King
On Sun, May 04, 2014 at 01:12:53AM -0500, Felipe Contreras wrote: > So it looks like gcc is smarter now, and in trying to fix a few warnings > we generated hundreds more. > > This reverts commit e208f9cc7574f5980faba498d0aa30b4defeb34f. And now we've gone the other way, and re-enabled the initia