Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-26 Thread Dennis Kaarsemaker
On zo, 2013-06-23 at 15:33 -0700, Junio C Hamano wrote: Dennis Kaarsemaker den...@kaarsemaker.net writes: On zo, 2013-06-23 at 14:22 -0700, Junio C Hamano wrote: Dennis Kaarsemaker den...@kaarsemaker.net writes: Equality for wildcards is allowed and tested for, so do we really want

Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-26 Thread Junio C Hamano
Dennis Kaarsemaker den...@kaarsemaker.net writes: Apart from the exactly matching refspecs, does git in any other way treat this as a special case? Sorry, I do not quite understand, especially the exactly matching part, which as far as I know is not special (in other words, I am not sure what

Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-23 Thread Dennis Kaarsemaker
On vr, 2013-06-21 at 11:42 -0700, Junio C Hamano wrote: +(!fnmatch(refspec, remote-fetch[i].dst, 0) || + !fnmatch(remote-fetch[i].dst, refspec, 0))) { Does .dst always exist and is never a NULL? My quick scan of remote.c::parse_refspec_internal() tells me

Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-23 Thread Junio C Hamano
Dennis Kaarsemaker den...@kaarsemaker.net writes: Equality for wildcards is allowed and tested for, so do we really want to 'outlaw' equality of non-wildcard refspecs? I am not sure what you mean by equality for wildcards is allowed. Do you mean this pair of remote definition is sane and not

Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-23 Thread Dennis Kaarsemaker
On zo, 2013-06-23 at 14:22 -0700, Junio C Hamano wrote: Dennis Kaarsemaker den...@kaarsemaker.net writes: Equality for wildcards is allowed and tested for, so do we really want to 'outlaw' equality of non-wildcard refspecs? I am not sure what you mean by equality for wildcards is

Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-23 Thread Junio C Hamano
Dennis Kaarsemaker den...@kaarsemaker.net writes: On zo, 2013-06-23 at 14:22 -0700, Junio C Hamano wrote: Dennis Kaarsemaker den...@kaarsemaker.net writes: Equality for wildcards is allowed and tested for, so do we really want to 'outlaw' equality of non-wildcard refspecs? I am not

Re: [PATCH 1/3] remote: Add warnings about mixin --mirror and other remotes

2013-06-21 Thread Junio C Hamano
Dennis Kaarsemaker den...@kaarsemaker.net writes: When cloning a repo with --mirror, and adding more remotes later, Even though --mirror is not the only way to trigger this, I think it is good to mention it because it is the most common way to do so. get_stale_heads for origin will mark all