Re: [PATCH 2/2] entry.c: convert write_entry to use strbuf

2013-10-24 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Thu, Oct 24, 2013 at 12:52 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: The strcpy call in open_output_fd() implies that the output buffer must be at least 25 chars long. Hmph, where does that 25 come

Re: [PATCH 2/2] entry.c: convert write_entry to use strbuf

2013-10-24 Thread Duy Nguyen
On Fri, Oct 25, 2013 at 2:49 AM, Junio C Hamano gits...@pobox.com wrote: Duy Nguyen pclo...@gmail.com writes: On Thu, Oct 24, 2013 at 12:52 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: The strcpy call in open_output_fd() implies that the output

Re: [PATCH 2/2] entry.c: convert write_entry to use strbuf

2013-10-23 Thread Duy Nguyen
On Thu, Oct 24, 2013 at 12:52 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: The strcpy call in open_output_fd() implies that the output buffer must be at least 25 chars long. Hmph, where does that 25 come from? [snipped] Much better. Thanks. --