Re: [PATCH 2/3] i18n: Only extract comments marked by special tag

2014-04-18 Thread Junio C Hamano
Junio C Hamano writes: > Documentation/CodingGuidelines may want to have a sentence of two to > explain this, though. After re-reading what I sent out, I realized that the way I singled out multi-line comments was misleading. Here is an updated version. -- >8 -- Subject: [PATCH] i18n: mention

Re: [PATCH 2/3] i18n: Only extract comments marked by special tag

2014-04-18 Thread Junio C Hamano
Jiang Xin writes: >> I am not very happy with this change, as it would force us to >> special case "Translators" comment to follow a non-standard >> multi-line comment formatting convention. Is there a way to tell >> xgettext to accept both of these forms? >> >> /* TRANSLATORS: this is a

Re: [PATCH 2/3] i18n: Only extract comments marked by special tag

2014-04-17 Thread Jiang Xin
2014-04-18 2:08 GMT+08:00 Junio C Hamano : > Jiang Xin writes: > >> When extract l10n messages, we use "--add-comments" option to keep >> comments right above the l10n messages for references. But sometimes >> irrelevant comments are also extracted. For example in the following >> code block, th

Re: [PATCH 2/3] i18n: Only extract comments marked by special tag

2014-04-17 Thread Junio C Hamano
Jiang Xin writes: > When extract l10n messages, we use "--add-comments" option to keep > comments right above the l10n messages for references. But sometimes > irrelevant comments are also extracted. For example in the following > code block, the comment in line 2 will be extracted as comment f