Re: [PATCH 2/4] Prepare Git::SVN for extraction into its own file.

Michael G Schwern wrote: > On 2012.7.26 10:18 PM, Junio C Hamano wrote: > > Again, I agree with you that passing $prefix as one of the arguments > > to ->new is the right thing to do in the final state after applying > > the whole series. I don't know if later steps in your patch series > > will

Re: [PATCH 2/4] Prepare Git::SVN for extraction into its own file.

On 2012.7.26 10:18 PM, Junio C Hamano wrote: > Forgot to sign-off, or are you still unsure about this step? I just never think to do it. It's just a line in the commit message, right? There's no crypto involved like tag -s. Is it a blocker? I guess I can write a msg-filter if it's important.

Re: [PATCH 2/4] Prepare Git::SVN for extraction into its own file.

Junio C Hamano writes: > "Michael G. Schwern" writes: > >> From: "Michael G. Schwern" >> >> This means it should be able to load without git-svn being loaded. >> >> * Load Git.pm on its own and all the needed command functions. >> >> * It needs to grab at a git-svn lexical $_prefix representing

Re: [PATCH 2/4] Prepare Git::SVN for extraction into its own file.

"Michael G. Schwern" writes: > From: "Michael G. Schwern" > > This means it should be able to load without git-svn being loaded. > > * Load Git.pm on its own and all the needed command functions. > > * It needs to grab at a git-svn lexical $_prefix representing the --prefix > option. Provide