Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 11:29:30PM +0200, Nicolas Morey-Chaisemartin wrote: > > But the #ifdef above says 071700, which is 7.23.0. I wonder if we just > > got it wrong back then (maybe hex confusion with 7.17.0?). I have a > > build setup for old versions of curl, so I'll double-check that 7.19.4

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Nicolas Morey-Chaisemartin
Le 09/08/2017 à 23:17, Jeff King a écrit : > On Wed, Aug 09, 2017 at 08:03:05PM +0200, Nicolas Morey-Chaisemartin wrote: > -#if LIBCURL_VERSION_NUM >= 0x071700 -/* Use CURLOPT_KEYPASSWD as is */ -#elif LIBCURL_VERSION_NUM >= 0x070903 -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPA

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 08:03:05PM +0200, Nicolas Morey-Chaisemartin wrote: > >> -#if LIBCURL_VERSION_NUM >= 0x071700 > >> -/* Use CURLOPT_KEYPASSWD as is */ > >> -#elif LIBCURL_VERSION_NUM >= 0x070903 > >> -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD > >> -#else > >> -#define CURLOPT_KEYPASSWD

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 10:40:13AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > -#if LIBCURL_VERSION_NUM >= 0x071700 > > -/* Use CURLOPT_KEYPASSWD as is */ > > -#elif LIBCURL_VERSION_NUM >= 0x070903 > > -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD > > -#else > > -#define CURLOPT_KEY

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 10:29:04AM -0700, Stefan Beller wrote: > > Documentation/config.txt | 3 +-- > > http-push.c | 23 > > http-walker.c| 12 --- > > http.c | 56 > > +--- > >

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Nicolas Morey-Chaisemartin
Le 09/08/2017 à 19:40, Junio C Hamano a écrit : > Jeff King writes: > >> -#if LIBCURL_VERSION_NUM >= 0x071700 >> -/* Use CURLOPT_KEYPASSWD as is */ >> -#elif LIBCURL_VERSION_NUM >= 0x070903 >> -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD >> -#else >> -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERT

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Junio C Hamano
Jeff King writes: > -#if LIBCURL_VERSION_NUM >= 0x071700 > -/* Use CURLOPT_KEYPASSWD as is */ > -#elif LIBCURL_VERSION_NUM >= 0x070903 > -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD > -#else > -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERTPASSWD > -#endif > - This part I am not sure. Don't we st

Re: [PATCH 2/4] http: drop support for curl < 7.16.0

2017-08-09 Thread Stefan Beller
On Wed, Aug 9, 2017 at 5:01 AM, Jeff King wrote: > As discussed in the previous commit, Git is not well-tested > with old versions of curl (and in fact since v2.12.0 does > not even compile with versions older than 7.19.4). Let's > stop pretending we support curl that old and drop any > now-obslet