Pranit Bauva writes:
>> with the original
>>
>> case $# in
>> 0) reset to the branch ;;
>> 1) reset to the commit ;;
>> *) give usage and die ;;
>> esac
>>
>> and took the difference and reacted "ah, excess parameters are not
>> diagnosed in this function".
>>
>> Your calle
Hey Junio,
On Fri, Aug 26, 2016 at 9:59 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>>> Also this version fails to catch "bisect reset a b c" as an error, I
>>> suspect.
>>
>> It didn't when I tried it right now. Could you please elaborate on why
>> you think it can fail? There might be a
Pranit Bauva writes:
>> Also this version fails to catch "bisect reset a b c" as an error, I
>> suspect.
>
> It didn't when I tried it right now. Could you please elaborate on why
> you think it can fail? There might be a thing which I haven't tested.
My bad. I just compared your bisect_reset()
Hey Junio,
On Thu, Aug 25, 2016 at 2:42 AM, Junio C Hamano wrote:
>
> Pranit Bauva writes:
>
> > +static int bisect_reset(const char *commit)
> > +{
> > + struct strbuf branch = STRBUF_INIT;
> > +
> > + if (!commit) {
> > + if (strbuf_read_file(&branch, git_path_bisect_start(
Pranit Bauva writes:
> +static int bisect_reset(const char *commit)
> +{
> + struct strbuf branch = STRBUF_INIT;
> +
> + if (!commit) {
> + if (strbuf_read_file(&branch, git_path_bisect_start(), 0) < 1) {
Hmm, tricky but correct to do the "< 1" comparison. If the file
does n
5 matches
Mail list logo