Re: [PATCH v2 08/11] i18n: send-email: mark strings for translation
W dniu 26.09.2016 o 01:18, Junio C Hamano pisze:
> Vasco Almeida writes:
>
>> @@ -1403,7 +1412,7 @@ Message-Id: $message_id
>> if ($quiet) {
>> printf (($dry_run ? "Dry-" : "")."Sent %s\n", $subject);
>> } else {
>> -print (($dry_run ? "Dry-" : "")."OK. Log says:\n");
>> +print (($dry_run ? "Dry-" : ""). __("OK. Log says:\n"));
>
> I am not sure about this change. We either say Dry-Sent/Dry-OK
> (under --dry-run) or "Sent/OK"; don't you want "dry-" part also
> translated?
Actually, we would probably want to unfold it, that is use
__("Dry-OK. Log says:\n") and __("OK. Log says:\n"), etc.
--
Jakub Narębski
Re: [PATCH v2 08/11] i18n: send-email: mark strings for translation
Vasco Almeida writes:
> @@ -1403,7 +1412,7 @@ Message-Id: $message_id
> if ($quiet) {
> printf (($dry_run ? "Dry-" : "")."Sent %s\n", $subject);
> } else {
> - print (($dry_run ? "Dry-" : "")."OK. Log says:\n");
> + print (($dry_run ? "Dry-" : ""). __("OK. Log says:\n"));
I am not sure about this change. We either say Dry-Sent/Dry-OK
(under --dry-run) or "Sent/OK"; don't you want "dry-" part also
translated?
Re: [PATCH v2 08/11] i18n: send-email: mark strings for translation
Vasco Almeida writes:
> - $_ = ask("What to do with this address? ([q]uit|[d]rop|[e]dit):
> ",
> + # TRANSLATORS: Make sure to include [q] [d] [e] in your
> + # translation. The program will only accept English input
> + # at this point.
> + $_ = ask(__("What to do with this address?
> ([q]uit|[d]rop|[e]dit): "),
> valid_re => qr/^(?:quit|q|drop|d|edit|e)/i,
> default => 'q');
> ...
> - $_ = ask("Send this email? ([y]es|[n]o|[q]uit|[a]ll): ",
> + # TRANSLATORS: Make sure to include [y] [n] [q] [a] in your
> + # translation. The program will only accept English input
> + # at this point.
> + $_ = ask(__("Send this email? ([y]es|[n]o|[q]uit|[a]ll): "),
>valid_re => qr/^(?:yes|y|no|n|quit|q|all|a)/i,
>default => $ask_default);
The same comment as the one for the prompt in "add -i" applies
here. If something should not be translated, perhaps we are better
off pushing it outside __(), no?
