Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

2013-04-06 Thread Felipe Contreras
On Sat, Apr 6, 2013 at 9:32 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Also, add a new option: 'auto', so if there's more than one patch, the >> cover letter is generated, otherwise it's not. > > Very sensible goal. > >> This has the slight disadvantage that a piece of code will al

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

2013-04-06 Thread Junio C Hamano
Felipe Contreras writes: > Also, add a new option: 'auto', so if there's more than one patch, the > cover letter is generated, otherwise it's not. Very sensible goal. > This has the slight disadvantage that a piece of code will always be run > even if the user doesn't want a cover letter, and t

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

2013-04-06 Thread Matthieu Moy
Felipe Contreras writes: > +format.cover-letter:: We normally use camelCase, so format.coverLetter, not cover-letter. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

2013-04-06 Thread Matthieu Moy
Felipe Contreras writes: >> Perhaps you can clarify this: Controls whether to generate a >> cover-letter when format-patch is invoked. Can be true, false, or >> auto. "auto" generates a cover-letter only when generating more than >> one patch. > > That's good, but I believe if we say it's a boo

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

2013-04-06 Thread Felipe Contreras
On Sat, Apr 6, 2013 at 6:43 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> Also, add a new option: 'auto', so if there's more than one patch, the >> cover letter is generated, otherwise it's not. > > Awesome! I wanted to fix this myself, but got sidetracked with the > whole submodul

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

2013-04-06 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > Also, add a new option: 'auto', so if there's more than one patch, the > cover letter is generated, otherwise it's not. Awesome! I wanted to fix this myself, but got sidetracked with the whole submodules thing. > +format.cover-letter:: > + Allows to configure the