Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword

2014-09-21 Thread Fabian Ruch
Hi Michael, On 08/13/2014 02:47 PM, Michael Haggerty wrote: > On 08/07/2014 01:59 AM, Fabian Ruch wrote: >> pick and reword are atomic to-do list commands in the sense that they >> open a new task which is closed after the respective command is >> completed. squash and fixup are not atomic. They c

Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword

2014-08-14 Thread Fabian Ruch
Hi, Michael Haggerty writes: > On 08/07/2014 01:59 AM, Fabian Ruch wrote: >> Lift the general unknown option blockade for the pick and reword >> commands. If `do_cmd` comes across one of the options `--signoff` and >> `--reset-author` while parsing a to-do entry and the scheduled >> command is eit

Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword

2014-08-13 Thread Michael Haggerty
On 08/07/2014 01:59 AM, Fabian Ruch wrote: > pick and reword are atomic to-do list commands in the sense that they > open a new task which is closed after the respective command is > completed. squash and fixup are not atomic. They create a new task > which is not completed until the last squash or

Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword

2014-08-12 Thread Fabian Ruch
Hi Thomas, Thomas Rast writes: > Fabian Ruch writes: >> @@ -634,21 +644,24 @@ do_replay () { >> comment_for_reflog pick >> >> mark_action_done >> -do_pick $sha1 || die_with_patch $sha1 "Could not apply $sha1... >> $rest" >> +eval do_pick $opts

Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword

2014-08-08 Thread Thomas Rast
Fabian Ruch writes: > @@ -634,21 +644,24 @@ do_replay () { > comment_for_reflog pick > > mark_action_done > - do_pick $sha1 || die_with_patch $sha1 "Could not apply $sha1... > $rest" > + eval do_pick $opts $sha1 \ > + || d