On Wed, May 29, 2013 at 11:42 AM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> Junio C Hamano wrote:
>>> Felipe Contreras writes:
>>>
>>> > +wanted = get_config('remote-bzr.branches').rstrip().split(', ')
>>>
>>> Two minor nits and one design suggestion:
>>>
>>> - Why rstrip() not
Felipe Contreras writes:
> Junio C Hamano wrote:
>> Felipe Contreras writes:
>>
>> > +wanted = get_config('remote-bzr.branches').rstrip().split(', ')
>>
>> Two minor nits and one design suggestion:
>>
>> - Why rstrip() not strip()?
>
> The purpose of the strip is to remove the _single_
Junio C Hamano wrote:
> Felipe Contreras writes:
>
> > +wanted = get_config('remote-bzr.branches').rstrip().split(', ')
>
> Two minor nits and one design suggestion:
>
> - Why rstrip() not strip()?
The purpose of the strip is to remove the _single_ "\n" at the end that
subprocess communi
Felipe Contreras writes:
> +wanted = get_config('remote-bzr.branches').rstrip().split(', ')
Two minor nits and one design suggestion:
- Why rstrip() not strip()? It appears that this only is helping
an end-user "mistake" like this:
git config remote-bzr.branches 'trunk, devel,
4 matches
Mail list logo