Re: [PATCH v2 7/8] remote-bzr: reorganize the way 'wanted' works

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 11:42 AM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Junio C Hamano wrote: >>> Felipe Contreras writes: >>> >>> > +wanted = get_config('remote-bzr.branches').rstrip().split(', ') >>> >>> Two minor nits and one design suggestion: >>> >>> - Why rstrip() not

Re: [PATCH v2 7/8] remote-bzr: reorganize the way 'wanted' works

2013-05-29 Thread Junio C Hamano
Felipe Contreras writes: > Junio C Hamano wrote: >> Felipe Contreras writes: >> >> > +wanted = get_config('remote-bzr.branches').rstrip().split(', ') >> >> Two minor nits and one design suggestion: >> >> - Why rstrip() not strip()? > > The purpose of the strip is to remove the _single_

Re: [PATCH v2 7/8] remote-bzr: reorganize the way 'wanted' works

2013-05-28 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > +wanted = get_config('remote-bzr.branches').rstrip().split(', ') > > Two minor nits and one design suggestion: > > - Why rstrip() not strip()? The purpose of the strip is to remove the _single_ "\n" at the end that subprocess communi

Re: [PATCH v2 7/8] remote-bzr: reorganize the way 'wanted' works

2013-05-28 Thread Junio C Hamano
Felipe Contreras writes: > +wanted = get_config('remote-bzr.branches').rstrip().split(', ') Two minor nits and one design suggestion: - Why rstrip() not strip()? It appears that this only is helping an end-user "mistake" like this: git config remote-bzr.branches 'trunk, devel,