Re: [PATCH v3 0/5] cleanup duplicate name_compare() functions

2014-06-19 Thread Jeff King
On Thu, Jun 19, 2014 at 01:04:32AM -0700, Jeremiah Mahler wrote: > > After looking at the patches I suspect this should be a single patch. > > That way it's bisectable, and the changes outside of read-cache.c are > > small enough that it's not too much of a burden to review as a single > > patch.

Re: [PATCH v3 0/5] cleanup duplicate name_compare() functions

2014-06-19 Thread Jeremiah Mahler
Jonathan, On Wed, Jun 18, 2014 at 12:14:07PM -0700, Jonathan Nieder wrote: > Jeremiah Mahler wrote: > > > Jeremiah Mahler (5): > > cache: rename cache_name_compare() to name_compare() > > tree-walk.c: remove name_compare() function > > unpack-trees.c: remove name_compare() function > > di

Re: [PATCH v3 0/5] cleanup duplicate name_compare() functions

2014-06-18 Thread Jonathan Nieder
Jeremiah Mahler wrote: > Jeremiah Mahler (5): > cache: rename cache_name_compare() to name_compare() > tree-walk.c: remove name_compare() function > unpack-trees.c: remove name_compare() function > dir.c: rename to name_compare() > name-hash.c: rename to name_compare() > > cache.h