Derrick Stolee writes:
> diff --git a/commit-graph.h b/commit-graph.h
> new file mode 100644
> index 000..dc8c73a
> --- /dev/null
> +++ b/commit-graph.h
> @@ -0,0 +1,7 @@
> +#ifndef COMMIT_GRAPH_H
> +#define COMMIT_GRAPH_H
> +
> +extern char *write_commit_graph(const char *obj_dir);
> +
> +#e
On Mon, Feb 19, 2018 at 7:53 PM, Derrick Stolee wrote:
> +static int if_packed_commit_add_to_list(const struct object_id *oid,
> + struct packed_git *pack,
> + uint32_t pos,
> + void
On 2/23/2018 2:30 PM, Junio C Hamano wrote:
Derrick Stolee writes:
jt/binsearch-with-fanout introduces one when there is a 256-entry
fanout table (not the case here).
The bsearch() method in search.h (and used in
pack-write.c:need_large_offset) does not return the _position_ of a
found elem
Junio C Hamano writes:
>> I think the current name makes the following call very clear:
>
> It is still a strange name nevertheless.
Sorry for simply repeating "strange" without spelling out why in the
previous message. This certainly is subjective and depends on your
cultural background, but i
Derrick Stolee writes:
> jt/binsearch-with-fanout introduces one when there is a 256-entry
> fanout table (not the case here).
>
> The bsearch() method in search.h (and used in
> pack-write.c:need_large_offset) does not return the _position_ of a
> found element.
>
> Neither of these suit my need
On 2/20/2018 5:57 PM, Junio C Hamano wrote:
Derrick Stolee writes:
+#define GRAPH_OID_VERSION_SHA1 1
+#define GRAPH_OID_LEN_SHA1 20
This hardcoded 20 on the right hand side of this #define is probably
problematic. Unless you are planning to possibly store truncated
hash value for some futur
Derrick Stolee writes:
> +#define GRAPH_OID_VERSION_SHA1 1
> +#define GRAPH_OID_LEN_SHA1 20
This hardcoded 20 on the right hand side of this #define is probably
problematic. Unless you are planning to possibly store truncated
hash value for some future hash algorithm, GRAPH_OID_LEN_$HASH shoul
7 matches
Mail list logo