Re: [PATCH v5 00/10] transport-helper: updates
On 31.10.2013, at 19:10, Junio C Hamano wrote: > Max Horn writes: > >> On 31.10.2013, at 10:36, Felipe Contreras >> wrote: >> >>> Hi, >>> >>> Here are the patches that allow transport helpers to be completely >> transparent; >>> renaming branches, deleting them, custom refspecs, --force, >> --dry-run, >>> reporting forced update, everything works. >> >> I looked through this patch series in detail, and it looks fine to >> me. Indeed, it fixes several nuisances when using remote-helpers, and >> as such would be a definite win. > > Nice. > >> In other words: Would be really nice to see these applied! > > The series is sitting on the 'pu' branch, and I think there were > some "fixup" suggestions during the review, so it may need to be > rerolled before advancing to 'next'. You are of course right. Next time I comment, I'll make sure to check whether previous review suggestions have been picked up. signature.asc Description: Message signed with OpenPGP using GPGMail
Re: [PATCH v5 00/10] transport-helper: updates
Junio C Hamano writes: > Max Horn writes: > >> On 31.10.2013, at 10:36, Felipe Contreras >> wrote: >> >>> Hi, >>> >>> Here are the patches that allow transport helpers to be completely >> transparent; >>> renaming branches, deleting them, custom refspecs, --force, >> --dry-run, >>> reporting forced update, everything works. >> >> I looked through this patch series in detail, and it looks fine to >> me. Indeed, it fixes several nuisances when using remote-helpers, and >> as such would be a definite win. > > Nice. > >> In other words: Would be really nice to see these applied! > > The series is sitting on the 'pu' branch, and I think there were > some "fixup" suggestions during the review, so it may need to be > rerolled before advancing to 'next'. Ah, I spoke too early; this is v5, updated from v4. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/10] transport-helper: updates
On Thu, Oct 31, 2013 at 12:10 PM, Junio C Hamano wrote: > Max Horn writes: >> In other words: Would be really nice to see these applied! > > The series is sitting on the 'pu' branch, and I think there were > some "fixup" suggestions during the review, so it may need to be > rerolled before advancing to 'next'. The suggestions are applied, as you can see in the diff. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/10] transport-helper: updates
Max Horn writes: > On 31.10.2013, at 10:36, Felipe Contreras > wrote: > >> Hi, >> >> Here are the patches that allow transport helpers to be completely > transparent; >> renaming branches, deleting them, custom refspecs, --force, > --dry-run, >> reporting forced update, everything works. > > I looked through this patch series in detail, and it looks fine to > me. Indeed, it fixes several nuisances when using remote-helpers, and > as such would be a definite win. Nice. > In other words: Would be really nice to see these applied! The series is sitting on the 'pu' branch, and I think there were some "fixup" suggestions during the review, so it may need to be rerolled before advancing to 'next'. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/10] transport-helper: updates
On 31.10.2013, at 10:36, Felipe Contreras wrote: > Hi, > > Here are the patches that allow transport helpers to be completely > transparent; > renaming branches, deleting them, custom refspecs, --force, --dry-run, > reporting forced update, everything works. I looked through this patch series in detail, and it looks fine to me. Indeed, it fixes several nuisances when using remote-helpers, and as such would be a definite win. In other words: Would be really nice to see these applied! Cheers, Max signature.asc Description: Message signed with OpenPGP using GPGMail