Re: [PATCHv2] tag: add --edit option

2018-02-04 Thread Nicolas Morey-Chaisemartin
Le 02/02/2018 à 20:16, Eric Sunshine a écrit : > On Fri, Feb 2, 2018 at 11:48 AM, Nicolas Morey-Chaisemartin > wrote: >> What message do you suggest ? As I said in a previous mail, a >> simple "Editor failure, cancelling {commit, tag}" should be enough >> as launch_editor already outputs error

Re: [PATCHv2] tag: add --edit option

2018-02-02 Thread Eric Sunshine
On Fri, Feb 2, 2018 at 11:48 AM, Nicolas Morey-Chaisemartin wrote: > What message do you suggest ? As I said in a previous mail, a > simple "Editor failure, cancelling {commit, tag}" should be enough > as launch_editor already outputs error messages describing what > issue the editor had. > > I d

Re: [PATCHv2] tag: add --edit option

2018-02-02 Thread Nicolas Morey-Chaisemartin
Le 02/02/2018 à 10:57, Eric Sunshine a écrit : > On Fri, Feb 2, 2018 at 2:15 AM, Nicolas Morey-Chaisemartin > wrote: >> Le 02/02/2018 à 02:29, Eric Sunshine a écrit : >>> On Thu, Feb 1, 2018 at 12:21 PM, Nicolas Morey-Chaisemartin >>> wrote: - I'll post another series to fix the misleading

Re: [PATCHv2] tag: add --edit option

2018-02-02 Thread Eric Sunshine
On Fri, Feb 2, 2018 at 2:15 AM, Nicolas Morey-Chaisemartin wrote: > Le 02/02/2018 à 02:29, Eric Sunshine a écrit : >> On Thu, Feb 1, 2018 at 12:21 PM, Nicolas Morey-Chaisemartin >> wrote: >>> - I'll post another series to fix the misleading messages in both commit.c >>> and tag.c when launch_edi

Re: [PATCHv2] tag: add --edit option

2018-02-02 Thread Nicolas Morey-Chaisemartin
Le 02/02/2018 à 02:29, Eric Sunshine a écrit : > On Thu, Feb 1, 2018 at 12:21 PM, Nicolas Morey-Chaisemartin > wrote: >> Add a --edit option whichs allows modifying the messages provided by -m or >> -F, >> the same way git commit --edit does. >> >> Signed-off-by: Nicolas Morey-Chaisemartin >>

Re: [PATCHv2] tag: add --edit option

2018-02-01 Thread Eric Sunshine
On Thu, Feb 1, 2018 at 12:21 PM, Nicolas Morey-Chaisemartin wrote: > Add a --edit option whichs allows modifying the messages provided by -m or -F, > the same way git commit --edit does. > > Signed-off-by: Nicolas Morey-Chaisemartin > --- > Changes since v1: > - Fix usage string > - Use write_scr