Re: [PATCHv6] Add contrib/credentials/netrc with GPG support

2013-02-25 Thread Ted Zlatanov
On Fri, 8 Feb 2013 01:18:55 -0500 Jeff King wrote: >> +# the following check is copied from Net::Netrc, for non-GPG files >> +# OS/2 and Win32 do not handle stat in a way compatable with this check >> :-( JK> s/compatable/compatible/ This is from the Net::Netrc module. Fixed in my co

Re: [PATCHv6] Add contrib/credentials/netrc with GPG support

2013-02-07 Thread Jeff King
On Tue, Feb 05, 2013 at 07:38:58PM -0500, Ted Zlatanov wrote: > Add Git credential helper that can parse netrc/authinfo files. > > This credential helper supports multiple files, returning the first one > that matches. It checks file permissions and owner. For *.gpg files, > it will run GPG to

Re: [PATCHv6] Add contrib/credentials/netrc with GPG support

2013-02-07 Thread Junio C Hamano
Ted Zlatanov writes: > I agree this Makefile is not a good test to ship out. It was my quickie > test rig that I should have reworked before adding to the patch. Sorry. Nothing to be sorry about. Starting with quick-and-dirty and polishing for public consumption is what the review cycle is ab

Re: [PATCHv6] Add contrib/credentials/netrc with GPG support

2013-02-07 Thread Ted Zlatanov
On Thu, 07 Feb 2013 15:52:41 -0800 Junio C Hamano wrote: >> +@echo "=> Look for any entry in the default file set" >> +echo "" | ./git-credential-netrc -d -v get >> +@echo "=> Look for github.com in the default file set" >> +echo "host=google.com" | ./git-credential-netrc -d -v g

Re: [PATCHv6] Add contrib/credentials/netrc with GPG support

2013-02-07 Thread Junio C Hamano
Ted Zlatanov writes: > Add Git credential helper that can parse netrc/authinfo files. I think this line is redundant; we already know it on the Subject: line. > This credential helper supports multiple files, returning the first one > that matches. It checks file permissions and owner. For *.