Re: New special handing of '@' character broke my use case
On 08/14/2013 09:57 PM, Junio C Hamano wrote: > Johannes Sixt writes: > > [SNIP] > >> Stefano's use-case, where @/foo is turned into HEAD/foo, >> indicates a bug. >> >> In my opinion, the topic, which touches a central part of ref >> handling, was a bit hurried (and this report is a symptom of it), and >> I wouldn't mind seeing it reverted. > > Thanks; you said it much better than I did. I think the short-hand > is not a bad idea by itself, but the execution may need to be redone > a bit more carefully, and it is prudent to revert it from the > upcoming release. > Thanks both for taking care of this issue with the usual speed and clarity. Best regards, Stefano -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: New special handing of '@' character broke my use case
Johannes Sixt writes: > Am 14.08.2013 20:05, schrieb Junio C Hamano: >> Stefano Lattarini writes: >> >>> My problems is that some new automagical interpretation of the bare >>> @' character (introduced after 1.8.3) has destroyed my use case: >>> ... >>> I don't want to ask you to revert this new behaviour, but I'd like to >>> at least have an option to disable it. >> >> I do not think it is simply not worth the complexity to selectively >> disable it. If it is a regression, it is much better to simply >> revert, if we can (it appears that cdfd9483 (Add new @ shortcut for >> HEAD, 2013-05-07) can be reverted without any textual context, but >> there may already be new stuff that depends on the "@"). >> >> For the upcoming release, I am very much tempted to revert it and >> let the topic retried, by people who really want the "let's save >> four keystrokes and replace it with @ aka Shift-", >> without hurting your use case (and others), after the upcoming >> release. >> >> What do others think? > > Stefano's use-case, where @/foo is turned into HEAD/foo, indicates a bug. > > In my opinion, the topic, which touches a central part of ref > handling, was a bit hurried (and this report is a symptom of it), and > I wouldn't mind seeing it reverted. Thanks; you said it much better than I did. I think the short-hand is not a bad idea by itself, but the execution may need to be redone a bit more carefully, and it is prudent to revert it from the upcoming release. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: New special handing of '@' character broke my use case
Am 14.08.2013 20:05, schrieb Junio C Hamano: Stefano Lattarini writes: My problems is that some new automagical interpretation of the bare @' character (introduced after 1.8.3) has destroyed my use case: ... I don't want to ask you to revert this new behaviour, but I'd like to at least have an option to disable it. I do not think it is simply not worth the complexity to selectively disable it. If it is a regression, it is much better to simply revert, if we can (it appears that cdfd9483 (Add new @ shortcut for HEAD, 2013-05-07) can be reverted without any textual context, but there may already be new stuff that depends on the "@"). For the upcoming release, I am very much tempted to revert it and let the topic retried, by people who really want the "let's save four keystrokes and replace it with @ aka Shift-", without hurting your use case (and others), after the upcoming release. What do others think? Stefano's use-case, where @/foo is turned into HEAD/foo, indicates a bug. In my opinion, the topic, which touches a central part of ref handling, was a bit hurried (and this report is a symptom of it), and I wouldn't mind seeing it reverted. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: New special handing of '@' character broke my use case
[re-sending to the list, sorry Junio for the duplicate mail] On 08/14/2013 07:05 PM, Junio C Hamano wrote: > Stefano Lattarini writes: > >> My problems is that some new automagical interpretation of the bare >> @' character (introduced after 1.8.3) has destroyed my use case: >> ... >> I don't want to ask you to revert this new behaviour, but I'd like to >> at least have an option to disable it. > > I do not think it is simply not worth the complexity to selectively > disable it. If it is a regression, it is much better to simply > revert, if we can (it appears that cdfd9483 (Add new @ shortcut for > HEAD, 2013-05-07) can be reverted without any textual context, but > there may already be new stuff that depends on the "@"). > I'm not sure I want to force a revert simply to cater to a personal idiom of mine (and not that important). I'd first like to hear what the community thinks about the issue (with silence meaning "don't revert"). > For the upcoming release, I am very much tempted to revert it and > let the topic retried, by people who really want the "let's save > four keystrokes and replace it with @ aka Shift-", > without hurting your use case (and others), after the upcoming > release. > > What do others think? > I second this question :-) Thanks, Stefano -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: New special handing of '@' character broke my use case
Stefano Lattarini writes: > ... But in that case, I'd like some assurance that such a character > is not going to be turned into a magical character some time in the > future ;-) I'd say that any special letter could be considered a fair game by the next person who would want a funky short-cut. If you used "S" or something, e.g. "git branch S/ropic/1" etc., it would be very unlikely to conflict with any such future changes. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: New special handing of '@' character broke my use case
Stefano Lattarini writes: > My problems is that some new automagical interpretation of the bare > @' character (introduced after 1.8.3) has destroyed my use case: > ... > I don't want to ask you to revert this new behaviour, but I'd like to > at least have an option to disable it. I do not think it is simply not worth the complexity to selectively disable it. If it is a regression, it is much better to simply revert, if we can (it appears that cdfd9483 (Add new @ shortcut for HEAD, 2013-05-07) can be reverted without any textual context, but there may already be new stuff that depends on the "@"). For the upcoming release, I am very much tempted to revert it and let the topic retried, by people who really want the "let's save four keystrokes and replace it with @ aka Shift-", without hurting your use case (and others), after the upcoming release. What do others think? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
