Re: bw/transport-protocol-policy

2016-12-01 Thread Brandon Williams
On 12/01, Jeff King wrote: > On Thu, Dec 01, 2016 at 11:35:24AM -0800, Brandon Williams wrote: > > > > I wouldn't expect anyone to ever set GIT_PROTOCOL_FROM_USER=1, but it > > > does behave in a funny way here, overriding the "redirect" flag. I think > > > we'd want something more like: > > > >

Re: bw/transport-protocol-policy

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 11:35:24AM -0800, Brandon Williams wrote: > > I wouldn't expect anyone to ever set GIT_PROTOCOL_FROM_USER=1, but it > > does behave in a funny way here, overriding the "redirect" flag. I think > > we'd want something more like: > > > > if (redirect < 0) > > redirect

Re: bw/transport-protocol-policy

2016-12-01 Thread Brandon Williams
On 12/01, Jeff King wrote: > On Thu, Dec 01, 2016 at 10:14:15AM -0800, Brandon Williams wrote: > > > > 1. The new policy config lets you say "only allow this protocol when > > > the user specifies it". But when http.c calls is_transport_allowed(), > > > the latter has no idea that we a

Re: bw/transport-protocol-policy

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 10:14:15AM -0800, Brandon Williams wrote: > > 1. The new policy config lets you say "only allow this protocol when > > the user specifies it". But when http.c calls is_transport_allowed(), > > the latter has no idea that we are asking it about potential > >

Re: bw/transport-protocol-policy

2016-12-01 Thread Brandon Williams
On 12/01, Jeff King wrote: > On Mon, Nov 28, 2016 at 04:15:08PM -0800, Junio C Hamano wrote: > > > * bw/transport-protocol-policy (2016-11-09) 2 commits > > (merged to 'next' on 2016-11-16 at 1391d3eeed) > > + transport: add protocol policy config option > > + lib-proto-disable: variable name