Re: git-daemon: needs /root/.config/git/config?

2013-06-10 Thread Ian Kumlien
On Sun, Jun 09, 2013 at 02:47:57PM +0200, Bernhard R. Link wrote: > * Ian Kumlien [130605 13:31]: > > Yes, i agree, it's suboptimal but I for one would use getpwuid to get > > the home directory of the executing user to avoid this - though i don't > > know how portable it is (or if there is any ot

Re: git-daemon: needs /root/.config/git/config?

2013-06-09 Thread Bernhard R. Link
* Ian Kumlien [130605 13:31]: > Yes, i agree, it's suboptimal but I for one would use getpwuid to get > the home directory of the executing user to avoid this - though i don't > know how portable it is (or if there is any other issues) It's not only suboptimal but simply wrong. getpwuid gives at

Re: git-daemon: needs /root/.config/git/config?

2013-06-05 Thread Jeff King
On Wed, Jun 05, 2013 at 01:19:18PM +0200, Ian Kumlien wrote: > > Older versions of git silently ignored errors reading config files, but > > it was tightened in v1.8.1.1, as there can be quite serious implications > > to failing to read expected config (e.g., imagine transfer.fsckobjects, > > or r

Re: git-daemon: needs /root/.config/git/config?

2013-06-05 Thread Andreas Krey
On Wed, 05 Jun 2013 13:19:18 +, Ian Kumlien wrote: ... > Well, I have no idea of how to control HOME in xinetd - access to the > machine is limited and x doesn't give that much access (nothing really > important is actually stored in /root) Make xinetd execute '/usr/bin/env HOME=/home/yourstru

Re: git-daemon: needs /root/.config/git/config?

2013-06-05 Thread Ian Kumlien
On Tue, Jun 04, 2013 at 12:08:15PM -0400, Jeff King wrote: > On Tue, Jun 04, 2013 at 04:13:14PM +0200, Ian Kumlien wrote: > > > Due to the earlier problem I upgraded git on all machines > > and eneded up with a ubunut machine running in to problems. > > > > I started getting errors like: > > "fa

Re: git-daemon: needs /root/.config/git/config?

2013-06-04 Thread Junio C Hamano
Jeff King writes: > On Tue, Jun 04, 2013 at 12:10:25PM -0700, Jonathan Nieder wrote: > >> >> However, since changing user id and leaving $HOME is so common, there is >> >> a patch under consideration to loosen the check only for the case of >> >> EACCES on files in $HOME. That commit is 4698c8f (

Re: git-daemon: needs /root/.config/git/config?

2013-06-04 Thread Jeff King
On Tue, Jun 04, 2013 at 12:10:25PM -0700, Jonathan Nieder wrote: > >> However, since changing user id and leaving $HOME is so common, there is > >> a patch under consideration to loosen the check only for the case of > >> EACCES on files in $HOME. That commit is 4698c8f (config: allow > >> inacces

Re: git-daemon: needs /root/.config/git/config?

2013-06-04 Thread Junio C Hamano
Jonathan Nieder writes: > I could be remembering wrong, but I thought it was not so much "under > consideration" as "accepted for 1.8.4". I haven't heard any > compelling reasons not to apply it. > > Would it would make sense against earlier releases as well? True; the patch is queued on a topi

Re: git-daemon: needs /root/.config/git/config?

2013-06-04 Thread Jonathan Nieder
Johannes Sixt wrote: > Am 04.06.2013 18:08, schrieb Jeff King: >> However, since changing user id and leaving $HOME is so common, there is >> a patch under consideration to loosen the check only for the case of >> EACCES on files in $HOME. That commit is 4698c8f (config: allow >> inaccessible conf

Re: git-daemon: needs /root/.config/git/config?

2013-06-04 Thread Johannes Sixt
Am 04.06.2013 18:08, schrieb Jeff King: > Older versions of git silently ignored errors reading config files, but > it was tightened in v1.8.1.1, as there can be quite serious implications > to failing to read expected config (e.g., imagine transfer.fsckobjects, > or receive.deny* is ignored). > >

Re: git-daemon: needs /root/.config/git/config?

2013-06-04 Thread Jeff King
On Tue, Jun 04, 2013 at 04:13:14PM +0200, Ian Kumlien wrote: > Due to the earlier problem I upgraded git on all machines > and eneded up with a ubunut machine running in to problems. > > I started getting errors like: > "fatal: protocol error: bad line length character: fata" > > Which after so