AM-19 commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2050429370
> Please add a quick unit test
Have Added the same, Please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jbertram opened a new pull request, #4881:
URL: https://github.com/apache/activemq-artemis/pull/4881
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jbonofre commented on PR #1191:
URL: https://github.com/apache/activemq/pull/1191#issuecomment-2050189917
@kartg
1. Yes, I don't see problem to cherry-pick on `activemq-5.18.x`, I will do
that
2. To update website, you have to open a PR on
AM-19 commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2050149863
> Please add a quick unit test
Sure, Let me work on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kartg commented on PR #1191:
URL: https://github.com/apache/activemq/pull/1191#issuecomment-2050097118
thank you @jbonofre! Two follow-up questions:
1. Do you think this is safe to backport to the `5.18.x` branch?
2. What's the right way to update the [topologies
cshannon merged PR #1204:
URL: https://github.com/apache/activemq/pull/1204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
clebertsuconic commented on PR #4880:
URL:
https://github.com/apache/activemq-artemis/pull/4880#issuecomment-2050017298
@cardamon notice I'm keeping you as the author on the commit. as you
discovered the issue.
I went further and just removed the usage. if all my tests are good
clebertsuconic commented on PR #4576:
URL:
https://github.com/apache/activemq-artemis/pull/4576#issuecomment-2050015886
This is being replaced by
https://github.com/apache/activemq-artemis/pull/4880
--
This is an automated message from the Apache Git Service.
To respond to the
clebertsuconic closed pull request #4576: Fix a memory leak in HandlerBase.
URL: https://github.com/apache/activemq-artemis/pull/4576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
clebertsuconic commented on code in PR #4880:
URL: https://github.com/apache/activemq-artemis/pull/4880#discussion_r1561260496
##
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ProcessorBase.java:
##
@@ -117,13 +112,6 @@ public int shutdownNow(Consumer
clebertsuconic opened a new pull request, #4880:
URL: https://github.com/apache/activemq-artemis/pull/4880
co-authored: Clebert Suconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mattrpav commented on PR #1202:
URL: https://github.com/apache/activemq/pull/1202#issuecomment-2049929214
We should add a unit test for this JIRA
https://issues.apache.org/jira/browse/AMQ-9478 assigned to 6.2.0
--
This is an automated message from the Apache Git Service.
To respond to
jbonofre merged PR #1202:
URL: https://github.com/apache/activemq/pull/1202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gemmellr merged PR #9:
URL: https://github.com/apache/activemq-artemis-examples/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
clebertsuconic merged PR #4879:
URL: https://github.com/apache/activemq-artemis/pull/4879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mattrpav commented on PR #1204:
URL: https://github.com/apache/activemq/pull/1204#issuecomment-2049837685
I confirmed testing this locally using jconsole
```
INFO | Manual configuration update triggered
INFO | No material change to configuration in class path resource
clebertsuconic merged PR #4856:
URL: https://github.com/apache/activemq-artemis/pull/4856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tabish121 commented on PR #9:
URL:
https://github.com/apache/activemq-artemis-examples/pull/9#issuecomment-2049765432
> The example wasnt added to the verification script, so the CI checks wont
be running it.
>
> Might be worth reference the .txt file to create the stores from the
thezbyg closed pull request #1198: AMQ-9472 Add test for wildcard producer
breaking authorization
URL: https://github.com/apache/activemq/pull/1198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cshannon merged PR #1203:
URL: https://github.com/apache/activemq/pull/1203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andytaylor commented on code in PR #3:
URL:
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1561070218
##
artemis-plugin/craco.config.js:
##
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
andytaylor commented on code in PR #3:
URL:
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1561069126
##
LICENSE:
##
@@ -0,0 +1,326 @@
+
+ Apache License
+ Version 2.0, January 2004
+
mattrpav opened a new pull request, #1204:
URL: https://github.com/apache/activemq/pull/1204
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
brusdev opened a new pull request, #4879:
URL: https://github.com/apache/activemq-artemis/pull/4879
The lib folder includes netty-tcnative-boringssl-static artifacts
non-aligned with the netty-tcnative-version in pom.xml. Those artifacts are
included only because of zookeeper-server.
--
gemmellr commented on PR #9:
URL:
https://github.com/apache/activemq-artemis-examples/pull/9#issuecomment-2049636463
The example wasnt added to the verification script, so the CI checks wont be
running it.
Might be worth reference the .txt file to create the stores from the example
jbonofre commented on code in PR #1194:
URL: https://github.com/apache/activemq/pull/1194#discussion_r1560916109
##
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/HealthView.java:
##
@@ -167,6 +169,25 @@ public List healthList() throws Exception {
}
jbonofre commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2049540751
> It seems we already have a check for File system usage.
We have a check on the system usage, but not on the cursor.
It's not super critical.
--
This is an automated
mattrpav commented on code in PR #1194:
URL: https://github.com/apache/activemq/pull/1194#discussion_r1560887925
##
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/HealthView.java:
##
@@ -167,6 +169,25 @@ public List healthList() throws Exception {
}
cshannon merged PR #1200:
URL: https://github.com/apache/activemq/pull/1200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AM-19 commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2049205082
It seems we already have a check for File system usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jbonofre commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2049196650
For JDBC yes, but no test on KahaDB. We can check the system usage for
instance to see if the filesystem is not almost full.
--
This is an automated message from the Apache Git
AM-19 commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2049172132
> This first step checking the transports looks good to me. I would also
check the storage service.
Ideally the above mentioned code for JDBC Persistence check will work, with
the
jbonofre commented on PR #1194:
URL: https://github.com/apache/activemq/pull/1194#issuecomment-2049061906
This first step checking the transports looks good to me. I would also check
the storage service.
--
This is an automated message from the Apache Git Service.
To respond to the
jbonofre merged PR #1191:
URL: https://github.com/apache/activemq/pull/1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jbonofre opened a new pull request, #1202:
URL: https://github.com/apache/activemq/pull/1202
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
35 matches
Mail list logo
