[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-28 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487406011 @qihongxu just curious: which value have you configured for page-max-concurrent-io?

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-28 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487370942 @qihongxu I'm getting similar results to yours :) This pr together with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-28 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487370942 @qihongxu I'm getting similar results to yours :) This pr together with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-28 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487370942 @qihongxu I'm getting similar results to yours :) This pr together with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-28 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487370942 @qihongxu I'm getting similar results to yours :) This pr together with

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-25 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-486547865 The CI has shown good results: is basically on par of master :+1: Now my concern is just to

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-24 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-486242847 > Can you simplify the change somehow it only fix the TTSP. If you still feel strong about the loop

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-24 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-486242847 > Can you simplify the change somehow it only fix the TTSP. If you still feel strong about the loop