michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic
errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487705548
As it stands, this pr which is a refactor needs a few iterations imo. Not
everything should be inner classes.
michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic
errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496
So then i suggest leave the warning, warnings are there to suggest reviewing
and refactoring code, its not
michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic
errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476310
I agree about tone. And thats why i did not say MUST , and instead used
SHOULD which means ideally but if not
michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic
errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844
Just one example of classes that should be their own class is the algo
implementations.
michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic
errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487265140
If classes can be made static then actually they should be in their own
class file.
