[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-22 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533896432 @cjwmorgan-sol Thank you very much for your feedback.  I've added message tracing support to our backlog

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-20 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118 I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I read years ago, you shouldn't use checked exception as they violate open

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-20 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118 I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I read years ago, you shouldn't use checked exception as they violate open

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-20 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118 I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I read years ago, you shouldn't use checked exception as they violate open

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-18 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-532892930 @cjwmorgan-sol @michaelandrepearce Where are we with this one? Are we coming to any conclusions? I don't know if I am to make any adjustments or

[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging

2019-09-12 Thread GitBox
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160 That's understandable, but I was referring to the @cjwmorgan-sol suggestion to log this scenario: