jbertram merged PR #4329:
URL: https://github.com/apache/activemq-artemis/pull/4329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mattrpav commented on PR #956:
URL: https://github.com/apache/activemq/pull/956#issuecomment-1380708643
Ugh.. this approach switches nodes b/w stages. Got to make another pass..
Apache INFRA backlogged ~ 30 min to get a build node.
--
This is an automated message from the Apache Git
jbertram commented on PR #4329:
URL:
https://github.com/apache/activemq-artemis/pull/4329#issuecomment-1380697669
@clebertsuconic, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gemmellr commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1068355313
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java:
##
@@ -1513,7 +1524,137 @@ public String
mattrpav commented on PR #956:
URL: https://github.com/apache/activemq/pull/956#issuecomment-1380564668
@srajmane s390x build convo resumes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mattrpav closed pull request #907: Add Jenkinsfile for s390x
URL: https://github.com/apache/activemq/pull/907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
mattrpav commented on PR #907:
URL: https://github.com/apache/activemq/pull/907#issuecomment-1380562964
@srajmane I opened #956 which uses parameters (manual execution) as a first
step. Need to understand how long the build runs on Apache's s390x. If we get
quick turn-around times, we can
clebertsuconic commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1068362219
##
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java:
##
@@ -2026,10 +2028,20 @@ private
srajmane commented on PR #907:
URL: https://github.com/apache/activemq/pull/907#issuecomment-1380345152
@jbonofre @mattrpav
Could you please have a look? Thanks !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mattrpav merged PR #955:
URL: https://github.com/apache/activemq/pull/955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1068285808
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java:
##
@@ -1513,7 +1524,137 @@ public String
jbertram commented on PR #4320:
URL:
https://github.com/apache/activemq-artemis/pull/4320#issuecomment-138033
@ryan-highley, any feedback here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] opened a new pull request, #4331:
URL: https://github.com/apache/activemq-artemis/pull/4331
Bumps [keycloak-core](https://github.com/keycloak/keycloak) from 19.0.2 to
20.0.3.
Commits
NikitaShupletsov commented on code in PR #848:
URL: https://github.com/apache/activemq/pull/848#discussion_r1068833603
##
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##
@@ -1296,9 +1297,36 @@ public QueueMessageReference getMessage(String id) {
jbertram commented on PR #4122:
URL:
https://github.com/apache/activemq-artemis/pull/4122#issuecomment-1380764154
@michaelandrepearce, I haven't done any direct testing, just code review.
Can you elaborate on what you mean by "tested fully"? You mentioned doing an
upgrade previously. Is
michaelandrepearce commented on PR #4122:
URL:
https://github.com/apache/activemq-artemis/pull/4122#issuecomment-1380754439
@jbertram has anything been done to fix the airgap issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
michaelandrepearce commented on PR #4122:
URL:
https://github.com/apache/activemq-artemis/pull/4122#issuecomment-1380771228
@jbertram so in a true fully air gapped environment linux tools like xmllint
don't seem to like this. Which is used quite a bit in places to validate xml
changes
clebertsuconic commented on PR #4330:
URL:
https://github.com/apache/activemq-artemis/pull/4330#issuecomment-1380779486
I will run tests... if it's all good I will merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
NikitaShupletsov commented on code in PR #953:
URL: https://github.com/apache/activemq/pull/953#discussion_r1068483608
##
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##
@@ -2387,8 +2495,8 @@ private QueueMessageReference
clebertsuconic merged PR #4327:
URL: https://github.com/apache/activemq-artemis/pull/4327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jbertram commented on PR #4122:
URL:
https://github.com/apache/activemq-artemis/pull/4122#issuecomment-1380782116
@michaelandrepearce, so in order to reproduce the issue I need to create an
instance of the broker on an air-gapped system using the schema updates in this
PR and then run
clebertsuconic merged PR #4330:
URL: https://github.com/apache/activemq-artemis/pull/4330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
maxfortun commented on PR #949:
URL: https://github.com/apache/activemq/pull/949#issuecomment-1381016813
Closing this PR as a leaner approach was suggested. Submitting #950 as a
proposal in continuation of this discussion.
--
This is an automated message from the Apache Git Service.
To
jbertram commented on PR #4122:
URL:
https://github.com/apache/activemq-artemis/pull/4122#issuecomment-1380799784
@michaelandrepearce, I can't even get `xmllint` to validate the normal
`broker.xml` on a non-air-gapped system. Is there some trick to this? Here's
what I did:
1.
clebertsuconic merged PR #4328:
URL: https://github.com/apache/activemq-artemis/pull/4328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mattrpav commented on PR #956:
URL: https://github.com/apache/activemq/pull/956#issuecomment-1380901835
s390x compiled fine w/ multiple JDKs
Unit tests running now:
ref:
https://ci-builds.apache.org/blue/organizations/jenkins/ActiveMQ%2FActiveMQ/detail/PR-956/3/pipeline/174
--
clebertsuconic commented on PR #4330:
URL:
https://github.com/apache/activemq-artemis/pull/4330#issuecomment-1380942009
tests are good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
maxfortun commented on PR #950:
URL: https://github.com/apache/activemq/pull/950#issuecomment-1381020426
@mattrpav, as per our conversation in #949, reworked JobListener to have the
following lifecycle hooks. Thoughts?
Ended up refactoring `memory`, `kahadb`, and tests.
1.
michaelandrepearce commented on PR #4122:
URL:
https://github.com/apache/activemq-artemis/pull/4122#issuecomment-1380786448
@jbertram so air gapped, yes. Two things the team here found
1) xmllint didn't like it
2) we ignored our system process and bypassed xmllint pre check, and
NikitaShupletsov commented on code in PR #953:
URL: https://github.com/apache/activemq/pull/953#discussion_r1068481508
##
activemq-broker/src/main/java/org/apache/activemq/broker/scheduler/SchedulerBroker.java:
##
@@ -54,7 +54,7 @@
import org.slf4j.Logger;
import
jbertram commented on PR #4320:
URL:
https://github.com/apache/activemq-artemis/pull/4320#issuecomment-1380940556
@ryan-highley, no worries. I just didn't want this to fall completely off
our radar. Your next steps sounds good. I'll review again once you push. Thanks!
--
This is an
clebertsuconic commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1068389869
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##
@@ -174,6 +184,8 @@ public class
michaelandrepearce commented on PR #3479:
URL:
https://github.com/apache/activemq-artemis/pull/3479#issuecomment-1380758509
@jbertram i would like to still see this in, as long as we mark it
experimental or in incubation in docs, i personally support this.
--
This is an automated
gemmellr commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1068419406
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##
@@ -635,6 +648,27 @@ private void
ryan-highley commented on PR #4320:
URL:
https://github.com/apache/activemq-artemis/pull/4320#issuecomment-1380834817
@jbertram Sorry for the delay--day job and all
That makes sense. I was attempting to move the unmasking with as little
invasiveness as possible, hence the
andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1067989566
##
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java:
##
@@ -408,6 +410,8 @@ default Message setValidatedUserID(String
andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1067990421
##
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java:
##
@@ -392,7 +392,7 @@
andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1067990772
##
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenwireMessage.java:
##
@@ -137,6 +137,11
38 matches
Mail list logo
