[GitHub] [activemq] jbonofre closed pull request #412: [AMQ-7320] Upgrade to Jackson 2.10.1
jbonofre closed pull request #412: [AMQ-7320] Upgrade to Jackson 2.10.1 URL: https://github.com/apache/activemq/pull/412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #412: [AMQ-7320] Upgrade to Jackson 2.10.1
jbonofre commented on issue #412: [AMQ-7320] Upgrade to Jackson 2.10.1 URL: https://github.com/apache/activemq/pull/412#issuecomment-577556555 Superseded by Jackson 2.9.10.2 update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] twyszomirski commented on issue #2716: Allow setting message properties when sending messages via REST.
twyszomirski commented on issue #2716: Allow setting message properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2716#issuecomment-577546996 @michaelandrepearce @jbertram Nice, thanks guys. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] JiriOndrusek commented on issue #2099: [ARTEMIS-1879] Warnings in log when failover is executed after clean …
JiriOndrusek commented on issue #2099: [ARTEMIS-1879] Warnings in log when failover is executed after clean … URL: https://github.com/apache/activemq-artemis/pull/2099#issuecomment-577539336 @michaelandrepearce Hi, I don't work on this anymore. You can close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre merged pull request #425: AMQ-7357 - Update Pax URL
jbonofre merged pull request #425: AMQ-7357 - Update Pax URL URL: https://github.com/apache/activemq/pull/425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #425: AMQ-7357 - Update Pax URL
jbonofre commented on issue #425: AMQ-7357 - Update Pax URL URL: https://github.com/apache/activemq/pull/425#issuecomment-577533254 For the record (and next time ;) ), it would be great to set the target version in the commit comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] Havret edited a comment on issue #11: AMQNET-631: Restore session extensions api
Havret edited a comment on issue #11: AMQNET-631: Restore session extensions api URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577530079 I believe it was breaking for the folks who were using old versions of .net framework or mono. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] Havret edited a comment on issue #11: AMQNET-631: Restore session extensions api
Havret edited a comment on issue #11: AMQNET-631: Restore session extensions api URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577530079 I believe it was breaking for the folks who were using old version of .net framework or mono. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] Havret commented on issue #11: AMQNET-631: Restore session extensions api
Havret commented on issue #11: AMQNET-631: Restore session extensions api URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577530079 I believe it was breaking for the folks that were using old version of .net framework or mono. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq] jbonofre merged pull request #426: AMQ-7375 - Update Spring
jbonofre merged pull request #426: AMQ-7375 - Update Spring URL: https://github.com/apache/activemq/pull/426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2885: ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory
asfgit closed pull request #2885: ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory URL: https://github.com/apache/activemq-artemis/pull/2885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f closed pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached
wy96f closed pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] wy96f commented on issue #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached
wy96f commented on issue #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#issuecomment-577482746 @michaelandrepearce closing it for now, it needs more discussion and refinement :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2716: Allow setting message properties when sending messages via REST.
jbertram commented on issue #2716: Allow setting message properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2716#issuecomment-577397473 @michaelandrepearce, fair enough. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2893: ARTEMIS-1925 combine STRICT and OFF with redistribution
jbertram commented on issue #2893: ARTEMIS-1925 combine STRICT and OFF with redistribution URL: https://github.com/apache/activemq-artemis/pull/2893#issuecomment-577397011 @michaelandrepearce, I don't have any objections to that. I added the label. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2913: ARTEMIS-2571 Remove synchronization of ActiveMQServerImpl#getSessions()
asfgit closed pull request #2913: ARTEMIS-2571 Remove synchronization of ActiveMQServerImpl#getSessions() URL: https://github.com/apache/activemq-artemis/pull/2913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message.
michaelandrepearce commented on issue #2837: ARTEMIS-2476: New MQTT subscriptions receive older (not last published) retained message. URL: https://github.com/apache/activemq-artemis/pull/2837#issuecomment-577392389 @clebertsuconic i think you promised @assens to merge this, are you still planning to? i can if not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2716: Allow setting message properties when sending messages via REST.
michaelandrepearce commented on issue #2716: Allow setting message properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2716#issuecomment-577391774 @jbertram this work seems good, and it be a shame to lose, i will look to create a jira amend the commit and merge if no objection This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop
michaelandrepearce commented on issue #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop URL: https://github.com/apache/activemq-artemis/pull/2607#issuecomment-577391232 @franz1981 what's occurring on this one, you working on it, or is it dead and we can close for now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2099: [ARTEMIS-1879] Warnings in log when failover is executed after clean …
michaelandrepearce commented on issue #2099: [ARTEMIS-1879] Warnings in log when failover is executed after clean … URL: https://github.com/apache/activemq-artemis/pull/2099#issuecomment-577390824 @JiriOndrusek this can't merge, due to conflict as well as PR build wasn't successful. Are you still working on this or can we close the PR to keep the PR list clean. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached
michaelandrepearce commented on issue #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached URL: https://github.com/apache/activemq-artemis/pull/2785#issuecomment-577390291 @wy96f what's occurring on this, are you actively wanting to develop this further, or dropping it and we close the PR? Just on a bit of a new year clean up of PR's This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
franz1981 commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-577389284 @michaelandrepearce Please wait a bit more: I've an opened issue on Netty related to `ChunkedWriteHandler` that could simplify this one, when merged. sadly I haven't had much time to work on the Netty side of it and it has blocked this one by consequence :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2615: ARTEMIS-1230 Added artemis-bom
michaelandrepearce commented on issue #2615: ARTEMIS-1230 Added artemis-bom URL: https://github.com/apache/activemq-artemis/pull/2615#issuecomment-577389133 I think this PR can close, if it remains inactive and no discuss thread is sent in the next few weeks. Just to keep PR backlog only to those that are actively worked on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577388373 @michaelandrepearce I've yet to add some tests, change some name and cleanup some APIs by addressing some of the advices from @clebertsuconic , but feel free to take a look/review so I will address altogether: from the pov of journal loading (and ha shared store) I see that when the disk is fast enough this could be really a game changer together with the other optimizations already merged on master, if compared to 2.11 :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2893: ARTEMIS-1925 combine STRICT and OFF with redistribution
michaelandrepearce commented on issue #2893: ARTEMIS-1925 combine STRICT and OFF with redistribution URL: https://github.com/apache/activemq-artemis/pull/2893#issuecomment-577387909 @jbertram just reading discussion on this, i agree with you until next major version, we should avoid breaking changes. If you're leaving this parked, any objections if we mark the PR with the "Do not merge yet label" just so its clear and gets skipped when reviewing active PR's? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
michaelandrepearce commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577386732 just adding the DNMY label, as you said this isn't to be merged in first comment, just so its clearer when looking over all PR's. (I'm playing catchup from a nice long holiday :) ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
michaelandrepearce commented on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-577386149 @franz1981 i think you are good to merge this, its been open a long time, and seems no one has opposition This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2885: ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory
michaelandrepearce commented on issue #2885: ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory URL: https://github.com/apache/activemq-artemis/pull/2885#issuecomment-577385583 @wy96f i think you can merge this, seems no one has given opposition, and tests pass This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] michaelpearce-gain edited a comment on issue #11: Restore session extensions api
michaelpearce-gain edited a comment on issue #11: Restore session extensions api URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577374635 These were not part of 4.x and above builds so its been removed in later language versions, as its a extension its not really something that should be in API, as well they dont exist in JMS apis. As such it isnt a breaking change not having them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] michaelpearce-gain edited a comment on issue #11: Restore session extensions api
michaelpearce-gain edited a comment on issue #11: Restore session extensions api URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577374635 These were not part of 4.x and above builds so its been removed in later language versions, as its a extension its not really something that should be in API, as well they dont exist in JMS apis. As such it isnt a breaking change in 1.8, its been removed for some time technically. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] michaelpearce-gain commented on issue #11: Restore session extensions api
michaelpearce-gain commented on issue #11: Restore session extensions api URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577374635 These were not part of 4.x and above builds so its been removed in later language versions, as its a extension its not really something that should be in API, as well they dont exist in JMS apis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] michaelpearce-gain edited a comment on issue #12: NMS 2.0 WIP
michaelpearce-gain edited a comment on issue #12: NMS 2.0 WIP URL: https://github.com/apache/activemq-nms-api/pull/12#issuecomment-577371806 @HavretGC - start of migration of the JMS 2.0 methods to NMS (and additional message property for message delay), as you see this means you then get ability to have shared and shared durable consumers, which depending on broker security will allow a consumer to create those dynamically / remove need for fqqn queue consumer work arounds. Will need to add still JMSContext, JMSProducer, JMSConsumer apis also to align fully to JMS 2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] michaelpearce-gain edited a comment on issue #12: NMS 2.0 WIP
michaelpearce-gain edited a comment on issue #12: NMS 2.0 WIP URL: https://github.com/apache/activemq-nms-api/pull/12#issuecomment-577371806 @HavretGC - start of migration of the JMS 2.0 methods to NMS , as you see this means you then get ability to have shared and shared durable consumers, which depending on broker security will allow a consumer to create those dynamically / remove need for fqqn queue consumer work arounds. Will need to add still JMSContext, JMSProducer, JMSConsumer apis also to align fully to JMS 2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-api] michaelpearce-gain commented on issue #12: NMS 2.0 WIP
michaelpearce-gain commented on issue #12: NMS 2.0 WIP URL: https://github.com/apache/activemq-nms-api/pull/12#issuecomment-577371806 @HavretGC - start of migration of the JMS 2.0 methods to NMS , as you see this means you then get ability to have shared and shared durable consumers, which depending on broker security will allow a consumer to create those dynamically / remove need for fqqn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369697534 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer You're still parsing the key at its exact position. It's comparing, but it's not parsing (there is no decoding involved). In additon, to compare `SimpleString` and `ByteBuf` is using another optimized method I've implemented some time ago that allow to compare them very quickly directly ie https://github.com/apache/activemq-artemis/blob/0293d8057441e6bfeb9e6533774862ffc86d74eb/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java#L346-L360 > in Java every time you do buffer.getInt(index) you will create a few bytes in memory. That's the signature of the Netty method: https://netty.io/4.0/api/io/netty/buffer/ByteBuf.html#getInt-int- it would return a primitive `int`: it's not allocating anything. I've taken care to design that method to be garbage-free :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369697534 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer You're still parsing the key at its exact position. I'm comparing, but I'm not parsing (there is no decoding involved). In additon, to compare `SimpleString` and `ByteBuf` is using another optimized method I've implemented some time ago that allow to compare them very quickly directly ie https://github.com/apache/activemq-artemis/blob/0293d8057441e6bfeb9e6533774862ffc86d74eb/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java#L346-L360 > in Java every time you do buffer.getInt(index) you will create a few bytes in memory. That's the signature of the Netty method: https://netty.io/4.0/api/io/netty/buffer/ByteBuf.html#getInt-int- it would return a primitive `int`: it's not allocating anything. I've taken care to design that method to be garbage-free :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369697534 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer You're still parsing the key at its exact position. Nope: to compare `SimpleString` and `ByteBuf` is using another optimized method I've implemented some time ago that allow to compare them very quickly directly ie https://github.com/apache/activemq-artemis/blob/0293d8057441e6bfeb9e6533774862ffc86d74eb/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java#L346-L360 > in Java every time you do buffer.getInt(index) you will create a few bytes in memory. That's the signature of the Netty method: https://netty.io/4.0/api/io/netty/buffer/ByteBuf.html#getInt-int- it would return a primitive `int`: it's not allocating anything. I've taken care to design that method to be garbage-free :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369697534 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer You're still parsing the key at its exact position. Nope: to compare `SimpleString` and `ByteBuf` is using another optimized method I've implemented some time ago that allow to compare them very quickly directly ie https://github.com/apache/activemq-artemis/blob/0293d8057441e6bfeb9e6533774862ffc86d74eb/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java#L345 > in Java every time you do buffer.getInt(index) you will create a few bytes in memory. That's the signature of the Netty method: https://netty.io/4.0/api/io/netty/buffer/ByteBuf.html#getInt-int- it would return a primitive `int`: it's not allocating anything. I've taken care to design that method to be garbage-free :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369659026 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369658086 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369657571 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer> "the risk is to find a value that matches the property we are searching for" So what? if someone uses the key as the value, all it will incur is for us to do the older semantic, which is to parse the whole buffer. and we would incur in the old semantic. Add a test with the value as the key, just to make sure.. although I doubt someone will use the property _HDR_SCHEDULED_TIME anywhere in the values :) and if they did it would still be fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577262343 >To make amqp to be faster then core we should start dropping boxed values as viable decoded types and just use primitives: that would help a lot That requires a new codec, I think it's on the way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577260402 >"the ideal thing would be to always place ScheduledDeliveryTime " in a fixed position (as first property?) @franz1981 : the ideal thing would be to use a fixed value within the protocol, like AMQP does. requiring a fixed position would pretty much be redefining the protocol, it would incur in versioning anyways. Using a fixed property would in fact require you to do versioning on the protocol, to make sure you still parse the whole buffer for older clients.. so it's not feasible without breaking compatibility, and if you break it, it would be best to do the right thing. I would say it's a no. .since AMQP takes care of it. we could instead invest to make AMQP faster than core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369654970 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer
[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577260402 >"the ideal thing would be to always place ScheduledDeliveryTime " in a fixed position (as first property?) @franz1981 : the ideal thing would be to use a fixed value within the protocol, like what AMQP guys are doing. it would pretty much be redefining the protocol, it would incur in versioning anyways. Using a fixed property would in fact require you to do versioning on the protocol, to make sure you still parse the whole buffer for older clients.. so it's not feasible without breaking compatibility, and if you break it, it would be best to do the right thing. I would say it's a no. .since AMQP takes care of it. we could instead invest to make AMQP faster than core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577260402 >> "the ideal thing would be to always place ScheduledDeliveryTime" the ideal thing would be to use a fixed value within the protocol, like what AMQP guys are doing. it would pretty much be redefining the protocol, it would incur in versioning anyways. Using a fixed property would in fact require you to do versioning on the protocol, to make sure you still parse the whole buffer for older clients.. so it's not feasible without breaking compatibility, and if you break it, it would be best to do the right thing. I would say it's a no. .since AMQP takes care of it. we could instead invest to make AMQP faster than core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577260402 >"the ideal thing would be to always place ScheduledDeliveryTime" @franz1981 : the ideal thing would be to use a fixed value within the protocol, like what AMQP guys are doing. it would pretty much be redefining the protocol, it would incur in versioning anyways. Using a fixed property would in fact require you to do versioning on the protocol, to make sure you still parse the whole buffer for older clients.. so it's not feasible without breaking compatibility, and if you break it, it would be best to do the right thing. I would say it's a no. .since AMQP takes care of it. we could instead invest to make AMQP faster than core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic commented on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577260402 "the ideal thing would be to always place ScheduledDeliveryTime" the ideal thing would be to use a fixed value within the protocol, like what AMQP guys are doing. it would pretty much be redefining the protocol, it would incur in versioning anyways. Using a fixed property would in fact require you to do versioning on the protocol, to make sure you still parse the whole buffer for older clients.. so it's not feasible without breaking compatibility, and if you break it, it would be best to do the right thing. I would say it's a no. .since AMQP takes care of it. we could instead invest to make AMQP faster than core. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary
clebertsuconic commented on a change in pull request #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369652515 ## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java ## @@ -372,6 +372,79 @@ private synchronized void forEachInternal(BiConsumer
[GitHub] [activemq] jbonofre merged pull request #427: AMQ-7373 - Updating Jolokia
jbonofre merged pull request #427: AMQ-7373 - Updating Jolokia URL: https://github.com/apache/activemq/pull/427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary
franz1981 edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577050668 @clebertsuconic The downside of this optimization is that it still need to read the whole part of buffer with the properties in the best case: the ideal thing would be to always place `ScheduledDeliveryTime` in a fixed position (as first property?) I see that the last change on journal hasn't lowered the CI test time, but probably increased it: I have yet to verify it by trying the previous commit. And, in addition, I see there are some test failures, intermittent, but these next 3 days I will travel and canno verify if the test failures are real and due to some of my latest changes (think not TBH) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
