[GitHub] [hive] rbalamohan commented on a change in pull request #1340: HIVE-23953 : Use task counter information to compute keycount during hashtable loading

rbalamohan commented on a change in pull request #1340: URL: https://github.com/apache/hive/pull/1340#discussion_r464815905 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java ## @@ -125,13 +126,24 @@ public void

[GitHub] [hive] jcamachor commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

jcamachor commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r464764059 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java ## @@ -53,6 +53,34 @@ private static final Logger LOG =

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-668367912 @kgyrtkirk @jcamachor Could you please take a look? This is an automated message from the Apache Git Service.

[GitHub] [hive] dengzhhu653 commented on pull request #1242: HIVE-20441: NPE in GenericUDF when hive.allow.udf.load.on.demand is s…

dengzhhu653 commented on pull request #1242: URL: https://github.com/apache/hive/pull/1242#issuecomment-668366427 Hi @pvary, Is there anything I can do to move this forward? This is an automated message from the Apache Git

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-668358395 cc @sunchao This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hive] viirya opened a new pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya opened a new pull request #1356: URL: https://github.com/apache/hive/pull/1356 ### What changes were proposed in this pull request? This PR proposes to shade Guava from hive-exec in Hive 2.3 branch. ### Why are the changes needed? When trying to

[GitHub] [hive] github-actions[bot] closed pull request #1021: HIVE-23353 : Atlas metadata replication scheduling

github-actions[bot] closed pull request #1021: URL: https://github.com/apache/hive/pull/1021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] jcamachor commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

jcamachor commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464729855 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java ## @@ -49,6 +50,8 @@ import com.google.common.collect.Lists; import

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464722308 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java ## @@ -205,7 +205,9 @@ DROP_MAPPING("DROP MAPPING",

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464722096 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java ## @@ -283,6 +283,33 @@ public Object process(Node nd, Stack

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464722011 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java ## @@ -49,6 +50,8 @@ import com.google.common.collect.Lists; import

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464721831 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/PrepareStatementAnalyzer.java ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464714632 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1619,6 +1620,9 @@ public static ColStatistics

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464713600 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464710291 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464709177 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] jcamachor commented on pull request #1147: HIVE-23716: Support Anti Join in Hive

jcamachor commented on pull request #1147: URL: https://github.com/apache/hive/pull/1147#issuecomment-668281996 @maheshk114 , thanks for addressing the first batch of comments. PR looks better. I have done a second pass and left some additional comments that should be addressed before

[GitHub] [hive] jcamachor commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

jcamachor commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r464673502 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java ## @@ -747,6 +747,8 @@ public static RewritablePKFKJoinInfo

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464701187 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r464698359 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache

[GitHub] [hive] vihangk1 commented on a change in pull request #1355: send tableId to get_partition APIs

vihangk1 commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r464689406 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3258,8 +3260,19 @@ public Partition createPartition(Table tbl, Map partSpec)

[GitHub] [hive] kishendas opened a new pull request #1355: send tableId to get_partition APIs

kishendas opened a new pull request #1355: URL: https://github.com/apache/hive/pull/1355 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] jcamachor merged pull request #1326: HIVE-23941: Refactor TypeCheckProcFactory to be database agnostic

jcamachor merged pull request #1326: URL: https://github.com/apache/hive/pull/1326 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] mustafaiman commented on a change in pull request #1352: HIVE-23975: Reuse evicted keys from aggregation buffers

mustafaiman commented on a change in pull request #1352: URL: https://github.com/apache/hive/pull/1352#discussion_r464532531 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/wrapper/VectorHashKeyWrapperGeneral.java ## @@ -262,6 +255,138 @@ private void

[GitHub] [hive] mustafaiman commented on a change in pull request #1352: HIVE-23975: Reuse evicted keys from aggregation buffers

mustafaiman commented on a change in pull request #1352: URL: https://github.com/apache/hive/pull/1352#discussion_r464523610 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java ## @@ -514,7 +526,8 @@ private void

[GitHub] [hive] zabetak commented on a change in pull request #1331: HIVE-23946: Improve control flow and error handling in QTest dataset loading/unloading

zabetak commented on a change in pull request #1331: URL: https://github.com/apache/hive/pull/1331#discussion_r464505336 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java ## @@ -84,23 +83,25 @@ public boolean initDataset(String

[GitHub] [hive] zabetak commented on a change in pull request #1331: HIVE-23946: Improve control flow and error handling in QTest dataset loading/unloading

zabetak commented on a change in pull request #1331: URL: https://github.com/apache/hive/pull/1331#discussion_r464503259 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java ## @@ -52,8 +51,8 @@ private File datasetDir;

[GitHub] [hive] kuczoram commented on a change in pull request #1327: HIVE-23763: Query based minor compaction produces wrong files when ro…

kuczoram commented on a change in pull request #1327: URL: https://github.com/apache/hive/pull/1327#discussion_r464501671 ## File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java ## @@ -115,6 +115,10 @@ void runCompactionQueries(HiveConf conf,

[GitHub] [hive] scarlin-cloudera opened a new pull request #1354: HIVE-23977: WIP, test for consolidation of partiton fetching.

scarlin-cloudera opened a new pull request #1354: URL: https://github.com/apache/hive/pull/1354 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [hive] kgyrtkirk closed pull request #1250: HIVE-23843: Improve key evictions in VectorGroupByOperator

kgyrtkirk closed pull request #1250: URL: https://github.com/apache/hive/pull/1250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kgyrtkirk commented on pull request #1341: HIVE-23959: Provide an option to wipe out column stats for partitioned tables in case of column removal

kgyrtkirk commented on pull request #1341: URL: https://github.com/apache/hive/pull/1341#issuecomment-668089074 @pvary could you please take another look? This is an automated message from the Apache Git Service. To respond

[GitHub] [hive] pvargacl commented on pull request #1230: HIVE-23819: Use ranges in ValidReadTxnList serialization

pvargacl commented on pull request #1230: URL: https://github.com/apache/hive/pull/1230#issuecomment-668087223 @pvary could you merge this? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hive] jcamachor closed pull request #1333: [DRAFT] remove stringLiteralSequence in parser

jcamachor closed pull request #1333: URL: https://github.com/apache/hive/pull/1333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464483465 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464476338 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464473125 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1641,28 +1645,26 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvargacl commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464472005 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] jcamachor closed pull request #1317: HIVE-23949: Introduce caching layer in HS2 to accelerate query compilation

jcamachor closed pull request #1317: URL: https://github.com/apache/hive/pull/1317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] jcamachor merged pull request #1351: [DRAFT] MSC local cache

jcamachor merged pull request #1351: URL: https://github.com/apache/hive/pull/1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] jcamachor merged pull request #1328: HIVE-23873: Querying Hive JDBCStorageHandler table fails with NPE whe…

jcamachor merged pull request #1328: URL: https://github.com/apache/hive/pull/1328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] jcamachor merged pull request #1349: HIVE-23973: Use SQL constraints to improve join reordering algorithm …

jcamachor merged pull request #1349: URL: https://github.com/apache/hive/pull/1349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kasakrisz commented on a change in pull request #1349: HIVE-23973: Use SQL constraints to improve join reordering algorithm …

kasakrisz commented on a change in pull request #1349: URL: https://github.com/apache/hive/pull/1349#discussion_r464309156 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java ## @@ -52,14 +55,34 @@ protected

[GitHub] [hive] HunterL closed pull request #1313: HIVE-23829: Compute Stats Incorrect for Binary Columns

HunterL closed pull request #1313: URL: https://github.com/apache/hive/pull/1313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] abstractdog commented on a change in pull request #1331: HIVE-23946: Improve control flow and error handling in QTest dataset loading/unloading

abstractdog commented on a change in pull request #1331: URL: https://github.com/apache/hive/pull/1331#discussion_r464382232 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java ## @@ -52,8 +51,8 @@ private File datasetDir;

[GitHub] [hive] kuczoram commented on a change in pull request #1327: HIVE-23763: Query based minor compaction produces wrong files when ro…

kuczoram commented on a change in pull request #1327: URL: https://github.com/apache/hive/pull/1327#discussion_r464369294 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java ## @@ -261,22 +326,77 @@ protected void

[GitHub] [hive] kuczoram commented on a change in pull request #1327: HIVE-23763: Query based minor compaction produces wrong files when ro…

kuczoram commented on a change in pull request #1327: URL: https://github.com/apache/hive/pull/1327#discussion_r464368518 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java ## @@ -217,6 +224,64 @@ void

[GitHub] [hive] szehonCriteo opened a new pull request #1353: HIVE-8950 : Add support in ParquetHiveSerde to create table schema fr…

szehonCriteo opened a new pull request #1353: URL: https://github.com/apache/hive/pull/1353 …om a parquet file ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing

[GitHub] [hive] kuczoram commented on a change in pull request #1327: HIVE-23763: Query based minor compaction produces wrong files when ro…

kuczoram commented on a change in pull request #1327: URL: https://github.com/apache/hive/pull/1327#discussion_r464313931 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java ## @@ -95,6 +98,10 @@ private void

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464312615 ## File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java ## @@ -618,7 +618,13 @@ public void testMultipleInserts() throws Exception {

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464311382 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1641,28 +1645,26 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464310228 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464309265 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1574,20 +1577,23 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464308530 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -2493,7 +2514,7 @@ private static Path chooseFile(Path baseOrDeltaDir, FileSystem

[GitHub] [hive] dengzhhu653 closed pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

dengzhhu653 closed pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464306341 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] szlta commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

szlta commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464303366 ## File path: llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java ## @@ -250,18 +255,71 @@ public void testGetOrcTailForPath()

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464304647 ## File path: llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java ## @@ -250,18 +255,71 @@ public void testGetOrcTailForPath()

[GitHub] [hive] jdere commented on pull request #1350: HIVE-23972: Add external client ID to LLAP external client

jdere commented on pull request #1350: URL: https://github.com/apache/hive/pull/1350#issuecomment-667863766 @prasanthj thanks for pointing that out - I've tried to update the patch to use hive.query.name This is an

[GitHub] [hive] klcopp commented on pull request #1346: HIVE-23966: Minor query-based compaction always results in delta dirs with minWriteId=1

klcopp commented on pull request #1346: URL: https://github.com/apache/hive/pull/1346#issuecomment-667836261 Closed and reopened to rerun tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] klcopp closed pull request #1346: HIVE-23966: Minor query-based compaction always results in delta dirs with minWriteId=1

klcopp closed pull request #1346: URL: https://github.com/apache/hive/pull/1346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] shameersss1 commented on a change in pull request #1328: HIVE-23873: Querying Hive JDBCStorageHandler table fails with NPE whe…

shameersss1 commented on a change in pull request #1328: URL: https://github.com/apache/hive/pull/1328#discussion_r464215422 ## File path: jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java ## @@ -59,9 +62,26 @@ public