Re: [PR] HIVE-28202: Incorrect projected column size after ORC upgrade to v1.6.7 [hive]

2024-04-17 Thread via GitHub
abstractdog commented on code in PR #5195: URL: https://github.com/apache/hive/pull/5195#discussion_r1570103070 ## ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java: ## @@ -1727,14 +1727,15 @@ private void populateAndCacheStripeDetails() throws IOException {

Re: [PR] HIVE-28202: Incorrect projected column size after ORC upgrade to v1.6.7 [hive]

2024-04-17 Thread via GitHub
abstractdog commented on code in PR #5195: URL: https://github.com/apache/hive/pull/5195#discussion_r1570103070 ## ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java: ## @@ -1727,14 +1727,15 @@ private void populateAndCacheStripeDetails() throws IOException {

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
ryukobayashi commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1570106440 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/AbstractFilterStringColLikeStringScalar.java: ## @@ -226,7 +226,7 @@ protected interface CheckerFacto

Re: [PR] HIVE-28202: Incorrect projected column size after ORC upgrade to v1.6.7 [hive]

2024-04-17 Thread via GitHub
abstractdog commented on code in PR #5195: URL: https://github.com/apache/hive/pull/5195#discussion_r1570103070 ## ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java: ## @@ -1727,14 +1727,15 @@ private void populateAndCacheStripeDetails() throws IOException {

Re: [PR] HIVE-28203: Flaky qtest mv_iceberg_orc5.q [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5200: URL: https://github.com/apache/hive/pull/5200#issuecomment-2063055063 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28204: Remove some HMS obsolete scripts [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5201: URL: https://github.com/apache/hive/pull/5201#issuecomment-2063040070 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2062962153 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28204: Remove some HMS obsolete scripts [hive]

2024-04-17 Thread via GitHub
dengzhhu653 commented on PR #5201: URL: https://github.com/apache/hive/pull/5201#issuecomment-2062951151 Under standalone-metastore/metastore-server/src/main/sql, there are scripts for 1.2.0, mainly for TestSchemaToolForMetastore to test the upgrade from 1.2.0. -- This is an automated mes

[PR] HIVE-28204: Remove the HMS 1.x init script [hive]

2024-04-17 Thread via GitHub
dengzhhu653 opened a new pull request, #5201: URL: https://github.com/apache/hive/pull/5201 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the cha

Re: [PR] HIVE-28203: Flaky qtest mv_iceberg_orc5.q [hive]

2024-04-17 Thread via GitHub
zhangbutao commented on PR #5200: URL: https://github.com/apache/hive/pull/5200#issuecomment-2062906598 I think this flaky qtest is related to [HIVE-28126](https://issues.apache.org/jira/browse/HIVE-28126) and [HIVE-28127](https://issues.apache.org/jira/browse/HIVE-28127) Could you help

[PR] HIVE-28203: Flaky qtest mv_iceberg_orc5.q [hive]

2024-04-17 Thread via GitHub
zhangbutao opened a new pull request, #5200: URL: https://github.com/apache/hive/pull/5200 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the chan

Re: [PR] Preparing branch for Hive-4.0.1 release [hive]

2024-04-17 Thread via GitHub
dengzhhu653 commented on PR #5199: URL: https://github.com/apache/hive/pull/5199#issuecomment-2062890156 We have some failures about "HiveMetaException: Unknown version specified for initialization: 4.0.1", we might need to add an entry<"4.0.1", "4.0.0"> to `EQUIVALENT_VERSIONS` in `MetaSto

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
ryukobayashi commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1569842435 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java: ## @@ -51,93 +53,83 @@ public FilterStringColLikeStringScalar(i

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2062798424 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2062633148 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5186: URL: https://github.com/apache/hive/pull/5186#issuecomment-2062526921 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569532221 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -8810,7 +8810,8 @@ private Operator genConversionSelectOperatorByAddPartition(String dest, QB qb

Re: [PR] HIVE-24167: TPC-DS query 14 fails while generating plan for the filter [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5077: URL: https://github.com/apache/hive/pull/5077#discussion_r1569512569 ## ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java: ## @@ -1046,11 +1046,16 @@ public Object process(Node nd, Stack stack, NodeProcessorCtx procCtx, Obje

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1533045609 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -8810,7 +8810,8 @@ private Operator genConversionSelectOperatorByAddPartition(String dest, QB qb

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1533045609 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -8810,7 +8810,8 @@ private Operator genConversionSelectOperatorByAddPartition(String dest, QB qb

Re: [PR] HIVE-26926: SHOW PARTITIONS for a non partitioned table should just throw execution error instead of full stack trace. [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5164: URL: https://github.com/apache/hive/pull/5164#issuecomment-2062184232 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569497802 ## ql/src/java/org/apache/hadoop/hive/ql/Context.java: ## @@ -256,6 +257,7 @@ public String toString() { public enum RewritePolicy { DEFAULT, +SINGLE_PARTITION

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569497420 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -1110,8 +1110,9 @@ public void validateSinkDesc(FileSinkDesc sinkDe

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569495716 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -544,14 +549,20 @@ private void commitWrite(Table table, String br

Re: [PR] HIVE-24167: TPC-DS query 14 fails while generating plan for the filter [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5077: URL: https://github.com/apache/hive/pull/5077#discussion_r1569491532 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java: ## @@ -202,6 +203,12 @@ public HiveTableScan copyIncludingTable(RelDataType

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2062147149 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28202: Incorrect projected column size after ORC upgrade to v1.6.7 [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5195: URL: https://github.com/apache/hive/pull/5195#issuecomment-2062038568 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569351921 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1187,6 +1187,11 @@ private List getPartitionsByQuery(

Re: [PR] WIP: Dont review [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2061867752 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569215581 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ## @@ -133,7 +140,7 @@ private List getPartitions(Table table, AlterTabl

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2061841970 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569209670 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -108,11 +122,17 @@ public static Partition getPartition(Hive db, Table table, Map p

Re: [PR] Preparing branch for Hive-4.0.1 release [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5199: URL: https://github.com/apache/hive/pull/5199#issuecomment-2061724728 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2061644070 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569079683 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -94,10 +97,21 @@ public static ExprNodeGenericFuncDesc makeUnaryPredicate(String fn,

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

2024-04-17 Thread via GitHub
zhangbutao commented on PR #5191: URL: https://github.com/apache/hive/pull/5191#issuecomment-2061588240 > LGTM +1, pending tests note: mv_iceberg_orc5 fails in master as well, looks like flaky `mv_iceberg_orc5.q` is flaky. Please see https://issues.apache.org/jira/browse/HIVE-28203

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
zhangbutao commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2061569108 > http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5190/3/tests I think `mv_iceberg_orc5.q` is a flaky test, as i have seen it in multiple CI. e.g. http://c

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
zhangbutao commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2061562165 > http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5190/3/tests I think `mv_iceberg_orc5.q` is a flaky test, as i have seen it in multiple CI. e.g. http://c

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569041910 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1187,6 +1187,11 @@ private List getPartitionsByQu

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569039181 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -8810,7 +8810,8 @@ private Operator genConversionSelectOperatorByAddPartition(String dest, Q

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569035919 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ## @@ -133,7 +140,7 @@ private List getPartitions(Table table, Alter

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569023720 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -108,11 +122,17 @@ public static Partition getPartition(Hive db, Table table, Ma

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569023720 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -108,11 +122,17 @@ public static Partition getPartition(Hive db, Table table, Ma

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569012829 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContext co

Re: [PR] HIVE-28121: Use direct SQL for transactional altering table parameter (#5129) [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5197: URL: https://github.com/apache/hive/pull/5197#issuecomment-2061499397 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
zhangbutao commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2061493095 http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5190/3/tests I think `mv_iceberg_orc5.q` is a flaky test, as i have seen it in multiple CI. e.g. http://c

Re: [PR] HIVE-28202: Incorrect projected column size after ORC upgrade to v1.6.7 [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5195: URL: https://github.com/apache/hive/pull/5195#issuecomment-2061483185 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569002561 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/PartitionUtils.java: ## @@ -94,10 +97,21 @@ public static ExprNodeGenericFuncDesc makeUnaryPredicate(String

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569000652 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContex

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1569000480 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContext co

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
difin commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568989334 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContext co

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568995126 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContex

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568977615 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2127,4 +2127,26 @@ public List getMergeTaskInputFiles(Propert

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568977615 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -2127,4 +2127,26 @@ public List getMergeTaskInputFiles(Propert

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568961100 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContex

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568961100 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContex

Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5123: URL: https://github.com/apache/hive/pull/5123#discussion_r1568956730 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java: ## @@ -44,22 +51,69 @@ public boolean run(CompactorContex

[PR] Preparing branch for Hive-4.0.1 release [hive]

2024-04-17 Thread via GitHub
deniskuzZ opened a new pull request, #5199: URL: https://github.com/apache/hive/pull/5199 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the chang

Re: [PR] HIVE-28121: Use direct SQL for transactional altering table parameter (#5129) [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on PR #5197: URL: https://github.com/apache/hive/pull/5197#issuecomment-2061243014 https://github.com/apache/hive/pull/5199, should fix the sys.q test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] WIP: Dont review [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2061237981 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-26926: SHOW PARTITIONS for a non partitioned table should just throw execution error instead of full stack trace. [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5164: URL: https://github.com/apache/hive/pull/5164#discussion_r1568773753 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java: ## @@ -90,12 +92,16 @@ public int execute() { LOG.warn("Error while table creation: ", e); r

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5191: URL: https://github.com/apache/hive/pull/5191#discussion_r1568783021 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java: ## @@ -108,4 +114,14 @@ public String getDisplayString(String[] children) { return getSta

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #5191: URL: https://github.com/apache/hive/pull/5191#discussion_r1568783021 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java: ## @@ -108,4 +114,14 @@ public String getDisplayString(String[] children) { return getSta

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

2024-04-17 Thread via GitHub
okumin commented on code in PR #5191: URL: https://github.com/apache/hive/pull/5191#discussion_r1568759804 ## ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java: ## @@ -1736,6 +1749,13 @@ private static boolean isWideningCast(ExprNodeGenericFuncDesc engfd) {

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5190: URL: https://github.com/apache/hive/pull/5190#issuecomment-2061058761 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27791 Eliminate totalSize check from test [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #4913: URL: https://github.com/apache/hive/pull/4913#issuecomment-2061052912 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1568668529 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java: ## @@ -51,93 +53,83 @@ public FilterStringColLikeStringScalar(int

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1568658648 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/AbstractFilterStringColLikeStringScalar.java: ## @@ -226,7 +226,7 @@ protected interface CheckerFactory

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2060907293 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1568668529 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java: ## @@ -51,93 +53,83 @@ public FilterStringColLikeStringScalar(int

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1568660176 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/AbstractFilterStringColLikeStringScalar.java: ## @@ -226,7 +226,7 @@ protected interface CheckerFactory

Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]

2024-04-17 Thread via GitHub
deniskuzZ commented on code in PR #4998: URL: https://github.com/apache/hive/pull/4998#discussion_r1568658648 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/AbstractFilterStringColLikeStringScalar.java: ## @@ -226,7 +226,7 @@ protected interface CheckerFactory

Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]

2024-04-17 Thread via GitHub
InvisibleProgrammer commented on code in PR #5186: URL: https://github.com/apache/hive/pull/5186#discussion_r1568517128 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java: ## @@ -82,7 +82,7 @@

Re: [PR] HIVE-28177: Announce Hive 1.x EOL [hive-site]

2024-04-17 Thread via GitHub
zabetak closed pull request #14: HIVE-28177: Announce Hive 1.x EOL URL: https://github.com/apache/hive-site/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]

2024-04-17 Thread via GitHub
InvisibleProgrammer commented on code in PR #5186: URL: https://github.com/apache/hive/pull/5186#discussion_r1568517978 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -705,12 +706,11 @@ public LockResponse lockM

Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]

2024-04-17 Thread via GitHub
InvisibleProgrammer commented on code in PR #5186: URL: https://github.com/apache/hive/pull/5186#discussion_r1568510154 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -705,12 +706,11 @@ public LockResponse lockM

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5191: URL: https://github.com/apache/hive/pull/5191#issuecomment-2060743845 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] Draft: ORC projected size fix for ACID [hive]

2024-04-17 Thread via GitHub
sonarcloud[bot] commented on PR #5195: URL: https://github.com/apache/hive/pull/5195#issuecomment-2060730403 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28131: Iceberg: Add support for Replace Branch. [hive]

2024-04-17 Thread via GitHub
zhangbutao commented on code in PR #5190: URL: https://github.com/apache/hive/pull/5190#discussion_r1568420879 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/snapshotref/branch/replace/AlterTableReplaceBranchRefAnalyzer.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apac

[PR] HIVE-28177: Announce Hive 1.x EOL [hive-site]

2024-04-17 Thread via GitHub
zabetak opened a new pull request, #14: URL: https://github.com/apache/hive-site/pull/14 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail