Re: [PR] HIVE-28266: Iceberg: select count(*) from data_files metadata tables … [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5253: URL: https://github.com/apache/hive/pull/5253#issuecomment-2116591244 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [WIP] Calcite upgrade 1.33 [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2116551481 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-25799: Add java rule [hive]

2024-05-16 Thread via GitHub
github-actions[bot] closed pull request #2866: HIVE-25799: Add java rule URL: https://github.com/apache/hive/pull/2866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HIVE-28266: Iceberg: select count(*) from data_files metadata tables … [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5253: URL: https://github.com/apache/hive/pull/5253#issuecomment-2116338497 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] HIVE-28266: Iceberg: select count(*) from data_files metadata tables … [hive]

2024-05-16 Thread via GitHub
difin opened a new pull request, #5253: URL: https://github.com/apache/hive/pull/5253 …gives wrong result ### What changes were proposed in this pull request? Modified Iceberg method "canComputeQueryUsingStats" to return false for queries over metadata tables to make

Re: [PR] WIP: Dont review [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2115880734 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28256: Iceberg: Major QB Compaction on partition level with evol… [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5248: URL: https://github.com/apache/hive/pull/5248#issuecomment-2115545762 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28262:Single column use MultiDelimitSerDe parse column error [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5252: URL: https://github.com/apache/hive/pull/5252#issuecomment-2115530555 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

2024-05-16 Thread via GitHub
kasakrisz commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1602810089 ## hplsql/src/main/java/org/apache/hive/hplsql/Var.java: ## @@ -629,6 +630,31 @@ else if (type == Type.STRING) { } return toString(); } + + public String

Re: [PR] HIVE-28254: CBO (Calcite Return Path): Multiple DISTINCT leads to wrong results [hive]

2024-05-16 Thread via GitHub
okumin commented on code in PR #5245: URL: https://github.com/apache/hive/pull/5245#discussion_r1603371712 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/opconventer/HiveGBOpConvUtil.java: ## @@ -1028,32 +1028,65 @@ private static OpAttr

Re: [PR] HIVE-28254: CBO (Calcite Return Path): Multiple DISTINCT leads to wrong results [hive]

2024-05-16 Thread via GitHub
okumin commented on code in PR #5245: URL: https://github.com/apache/hive/pull/5245#discussion_r1603378557 ## ql/src/test/results/clientpositive/llap/count.q.out: ## @@ -811,7 +811,7 @@ STAGE PLANS: Execution mode: llap Reduce Operator Tree:

Re: [PR] HIVE-28254: CBO (Calcite Return Path): Multiple DISTINCT leads to wrong results [hive]

2024-05-16 Thread via GitHub
okumin commented on code in PR #5245: URL: https://github.com/apache/hive/pull/5245#discussion_r1603371712 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/opconventer/HiveGBOpConvUtil.java: ## @@ -1028,32 +1028,65 @@ private static OpAttr

Re: [PR] HIVE-28254: CBO (Calcite Return Path): Multiple DISTINCT leads to wrong results [hive]

2024-05-16 Thread via GitHub
okumin commented on code in PR #5245: URL: https://github.com/apache/hive/pull/5245#discussion_r1603371712 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/opconventer/HiveGBOpConvUtil.java: ## @@ -1028,32 +1028,65 @@ private static OpAttr

Re: [PR] WIP: Dont review [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2115190273 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27956: Query based compactor implementation separation [hive]

2024-05-16 Thread via GitHub
zratkai commented on code in PR #5192: URL: https://github.com/apache/hive/pull/5192#discussion_r1602890188 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilderForInsertOnly.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] WIP: Dont review [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2114339652 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] HIVE-28262:Single column use MultiDelimitSerDe parse column error [hive]

2024-05-16 Thread via GitHub
LaughingVzr opened a new pull request, #5252: URL: https://github.com/apache/hive/pull/5252 ### What changes were proposed in this pull request? modify LazyStruct#findIndexes function and LazyStruct#parseMultiDelimit function, change fields.length Conditional judgment: ```java

Re: [PR] HIVE-27956: Query based compactor implementation separation [hive]

2024-05-16 Thread via GitHub
kuczoram commented on code in PR #5192: URL: https://github.com/apache/hive/pull/5192#discussion_r1602791269 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java: ## @@ -54,6 +54,8 @@ public abstract class QueryCompactor implements Compactor { private

Re: [PR] HIVE-28228: Remove redundant/unused sources maven profile [hive]

2024-05-16 Thread via GitHub
ayushtkn commented on PR #5224: URL: https://github.com/apache/hive/pull/5224#issuecomment-2114292111 hey @zabetak no strong opinions here, if others are convinced, I don't pose any objections -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HIVE-28228: Remove redundant/unused sources maven profile [hive]

2024-05-16 Thread via GitHub
zabetak commented on PR #5224: URL: https://github.com/apache/hive/pull/5224#issuecomment-2114274347 Hey @ayushtkn , did you see my latest comment? If you feel that this profile is useful let me know and I will close the JIRA and PR. -- This is an automated message from the Apache Git

Re: [PR] HIVE-28252: AssertionError when using HiveTableScan with a HepPlanner cluster [hive]

2024-05-16 Thread via GitHub
zabetak closed pull request #5244: HIVE-28252: AssertionError when using HiveTableScan with a HepPlanner cluster URL: https://github.com/apache/hive/pull/5244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [WIP] Calcite upgrade 1.33 [hive]

2024-05-16 Thread via GitHub
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2114253351 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28249: Parquet legacy timezone conversion converts march 1st to … [hive]

2024-05-16 Thread via GitHub
simhadri-g merged PR #5241: URL: https://github.com/apache/hive/pull/5241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28249: Parquet legacy timezone conversion converts march 1st to … [hive]

2024-05-16 Thread via GitHub
simhadri-g commented on code in PR #5241: URL: https://github.com/apache/hive/pull/5241#discussion_r1602718666 ## common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java: ## @@ -529,6 +529,7 @@ public enum ErrorMsg { PARQUET_FOOTER_ERROR(20022, "Failed to read parquet

Re: [PR] HIVE-28204: Remove some HMS obsolete scripts [hive]

2024-05-16 Thread via GitHub
dengzhhu653 commented on PR #5201: URL: https://github.com/apache/hive/pull/5201#issuecomment-2114130757 > @dengzhhu653 Given there is a RC for 2.3.10 release, should we retain the upgrade scripts from 2.3 to the latest version? This