Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

zhangbutao commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1816097987 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned tabl

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

zhangbutao commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1816098742 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -461,44 +460,46 @@ public void appendFiles(org.apache.hadoop.

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

zhangbutao commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1816098208 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java: ## @@ -518,11 +518,11 @@ public static Path getDumpPath(Path root, String dbName, String tableName) {

Re: [PR] HIVE-28580: Create table using import command gives ddl pointing to i… [hive]

dengzhhu653 merged PR #5512: URL: https://github.com/apache/hive/pull/5512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28576: Add jdbc tests for tpcds queries [hive]

soumyakanti3578 commented on PR #5510: URL: https://github.com/apache/hive/pull/5510#issuecomment-2435982440 @deniskuzZ No, TestTezTPCDS30TBPerfCliDriver generates logical plans and uses a stats dump. This is different because here we actually create tpcds tables in Postgres, create externa

Re: [PR] HIVE-28580: Create table using import command gives ddl pointing to i… [hive]

sonarcloud[bot] commented on PR #5512: URL: https://github.com/apache/hive/pull/5512#issuecomment-2436616031 ## [](https://sonarcloud.

Re: [PR] HIVE-28548: Subdivide memory size allocated to parallel operators [hive]

deniskuzZ commented on code in PR #5478: URL: https://github.com/apache/hive/pull/5478#discussion_r1814770611 ## ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java: ## @@ -385,17 +385,22 @@ public static int countOperatorsUpstream(Operator start, Set> operators, -

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28538: Post JDK11-Fix locale-related discrepancies in test cases between local and Jenkins environments [hive]

shivjha30 commented on code in PR #5476: URL: https://github.com/apache/hive/pull/5476#discussion_r1814726912 ## pom.xml: ## @@ -92,7 +92,7 @@ 1.0b3 --Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4 +-Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4 -Duser.country=US

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815371959 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java: ## @@ -559,4 +566,32 @@ public static List getPartitionNames(Table icebergTab

Re: [PR] HIVE-28581: Support Partition Prunning stats optimization for Iceberg tables [hive]

sonarcloud[bot] commented on PR #5498: URL: https://github.com/apache/hive/pull/5498#issuecomment-2436224195 ## [](https://sonarcloud.

Re: [PR] HIVE-20917: Support applyQuotesToAll option in OpenCSVSerde. [hive]

gigem commented on PR #5513: URL: https://github.com/apache/hive/pull/5513#issuecomment-2436114297 > @gigem, `crtseltbl_serdeprops.q` was affected by this change: https://ci.hive.apache.org/job/hive-precommit/job/PR-5513/4/testReport/org.apache.hadoop.hive.cli.split5/TestMiniLlapLocalCliDriv

Re: [PR] HIVE-28572: Support Distribute by and Cluster by clauses in CBO [hive]

sonarcloud[bot] commented on PR #5505: URL: https://github.com/apache/hive/pull/5505#issuecomment-2436146493 ## [](https://sonarcloud.

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815372588 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -248,7 +248,12 @@ default Map getOperatorDescProperties(OperatorDesc operatorDesc,

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815372588 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ## @@ -248,7 +248,12 @@ default Map getOperatorDescProperties(OperatorDesc operatorDesc,

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-17306: Support MySQL InnoDB Cluster [hive]

sonarcloud[bot] commented on PR #5516: URL: https://github.com/apache/hive/pull/5516#issuecomment-2435949673 ## [](https://sonarcloud.

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28581: Support Partition Prunning stats optimization for Iceberg tables [hive]

deniskuzZ commented on code in PR #5498: URL: https://github.com/apache/hive/pull/5498#discussion_r1815414460 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -425,6 +426,16 @@ public boolean canProvideBasicStatistics() {

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815403104 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java: ## @@ -943,9 +944,16 @@ private Long getRowCnt( } } else { // unpartitioned table

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815384224 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java: ## @@ -518,11 +518,11 @@ public static Path getDumpPath(Path root, String dbName, String tableName) {

Re: [PR] HIVE-28268: Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

deniskuzZ commented on code in PR #5215: URL: https://github.com/apache/hive/pull/5215#discussion_r1815370139 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -461,44 +460,46 @@ public void appendFiles(org.apache.hadoop.h

Re: [PR] HIVE-20917: Support applyQuotesToAll option in OpenCSVSerde. [hive]

deniskuzZ commented on PR #5513: URL: https://github.com/apache/hive/pull/5513#issuecomment-2435300905 @gigem, crtseltbl_serdeprops.q was affected by this change: https://ci.hive.apache.org/job/hive-precommit/job/PR-5513/4/testReport/org.apache.hadoop.hive.cli.split5/TestMiniLlapLocalCli

Re: [PR] HIVE-24167: TPC-DS query 14 fails while generating plan for the filter [hive]

okumin commented on code in PR #5452: URL: https://github.com/apache/hive/pull/5452#discussion_r1814927537 ## ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java: ## @@ -217,7 +230,11 @@ private void link(Object o1, Object o2, boolean mayMerge) { } if (mG

Re: [PR] HIVE-28520: Upgrade to datasketches 2.0.0 [hive]

zhangbutao commented on code in PR #5444: URL: https://github.com/apache/hive/pull/5444#discussion_r1814434765 ## ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java: ## @@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmp

Re: [PR] HIVE-28548: Subdivide memory size allocated to parallel operators [hive]

deniskuzZ commented on code in PR #5478: URL: https://github.com/apache/hive/pull/5478#discussion_r1814779374 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java: ## @@ -450,7 +450,7 @@ public void initialize(Configuration hconf) throws HiveException

Re: [PR] HIVE-20917: Support applyQuotesToAll option in OpenCSVSerde. [hive]

sonarcloud[bot] commented on PR #5513: URL: https://github.com/apache/hive/pull/5513#issuecomment-2435002317 ## [](https://sonarcloud.

Re: [PR] HIVE-28538: Post JDK11-Fix locale-related discrepancies in test cases between local and Jenkins environments [hive]

shivjha30 commented on code in PR #5476: URL: https://github.com/apache/hive/pull/5476#discussion_r1814726912 ## pom.xml: ## @@ -92,7 +92,7 @@ 1.0b3 --Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4 +-Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4 -Duser.country=US

Re: [PR] HIVE-28580: Create table using import command gives ddl pointing to i… [hive]

sonarcloud[bot] commented on PR #5512: URL: https://github.com/apache/hive/pull/5512#issuecomment-2434109016 ## [](https://sonarcloud.

Re: [PR] HIVE-28548: Subdivide memory size allocated to parallel operators [hive]

deniskuzZ commented on code in PR #5478: URL: https://github.com/apache/hive/pull/5478#discussion_r1814784286 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java: ## @@ -625,7 +625,7 @@ private void computeMemoryLimits() { aggregationBatchI

Re: [PR] HIVE-28548: Subdivide memory size allocated to parallel operators [hive]

deniskuzZ commented on code in PR #5478: URL: https://github.com/apache/hive/pull/5478#discussion_r1814761679 ## ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java: ## @@ -389,14 +390,14 @@ protected void initializeOp(Configuration hconf) throws HiveException {

Re: [PR] HIVE-28520: Upgrade to datasketches 2.0.0 [hive]

asolimando commented on code in PR #5444: URL: https://github.com/apache/hive/pull/5444#discussion_r1814750442 ## ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java: ## @@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmp

Re: [PR] HIVE-28537: Iceberg: allow only partition columns in the WHERE clause [hive]

sonarcloud[bot] commented on PR #5483: URL: https://github.com/apache/hive/pull/5483#issuecomment-2434917036 ## [](https://sonarcloud.

Re: [PR] HIVE-28576: Add jdbc tests for tpcds queries [hive]

deniskuzZ commented on PR #5510: URL: https://github.com/apache/hive/pull/5510#issuecomment-2434897398 @soumyakanti3578, why should it be MiniLlapDriver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] HIVE-28520: Upgrade to datasketches 2.0.0 [hive]

zhangbutao commented on code in PR #5444: URL: https://github.com/apache/hive/pull/5444#discussion_r1814434765 ## ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java: ## @@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmp

Re: [PR] [WIP][HIVE-28585]: Ensure SerDes is case insensitive for data type-'string' to align with HQL and SQL [hive]

sonarcloud[bot] commented on PR #5515: URL: https://github.com/apache/hive/pull/5515#issuecomment-2434597220 ## [](https://sonarcloud.

Re: [PR] HIVE-28520: Upgrade to datasketches 2.0.0 [hive]

zhangbutao commented on code in PR #5444: URL: https://github.com/apache/hive/pull/5444#discussion_r1814463586 ## ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java: ## @@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmp

Re: [PR] HIVE-28520: Upgrade to datasketches 2.0.0 [hive]

zhangbutao commented on code in PR #5444: URL: https://github.com/apache/hive/pull/5444#discussion_r1814468324 ## ql/src/test/results/clientpositive/llap/compute_kll_sketch.q.out: ## @@ -7,22 +7,25 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@alltypesorc A masked pat