InvisibleProgrammer commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2068697313
@deniskuzZ , thank you for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
deniskuzZ merged PR #5186:
URL: https://github.com/apache/hive/pull/5186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1574261500
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockMaterializa
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1572278628
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2065992945
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2065468089
## [](https://sonarcloud.
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1571301493
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1571300498
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1571297284
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1571296956
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2064207595
## [](https://sonarcloud.
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570904194
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570903634
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570900958
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570833298
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570784025
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570775252
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570771527
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570753908
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570753908
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570757232
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570745381
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570757232
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570753908
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1570745381
##
ql/src/test/org/apache/hadoop/hive/ql/materializedview/TestHeartbeatTxnRangeFunction.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2063252721
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2062526921
## [](https://sonarcloud.
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1568517128
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##
@@ -82,7 +82,7 @@
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1568517978
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockM
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1568510154
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockM
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2060079605
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2057781933
## [](https://sonarcloud.
zratkai commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1565469449
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockMaterializati
deniskuzZ commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2049271261
please don't merge without the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kasakrisz commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2049266842
> @kasakrisz , what do you think, what should be the expected behaviour when
the heartbeat fails:
>
> * should it cancel the query and Hive give an exception, so that the user
will
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2048449097
## [](https://sonarcloud.
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558992350
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockMaterializa
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558987660
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##
@@ -82,7 +82,7 @@ public He
deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558987660
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##
@@ -82,7 +82,7 @@ public He
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558969477
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##
@@ -82,7 +82,7 @@
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558969477
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##
@@ -82,7 +82,7 @@
InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558965679
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockM
sonarcloud[bot] commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2045920653
## [](https://sonarcloud.
aturoczy commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558094523
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -705,12 +706,11 @@ public LockResponse lockMaterializat
InvisibleProgrammer commented on PR #5186:
URL: https://github.com/apache/hive/pull/5186#issuecomment-2045795285
@kasakrisz , what do you think, what should be the expected behaviour when
the heartbeat fails:
- should it cancel the query and Hive give an exception, so that the user
will
InvisibleProgrammer opened a new pull request, #5186:
URL: https://github.com/apache/hive/pull/5186
It fails with the following error:
```
org.springframework.dao.InvalidDataAccessApiUsageException: SQL [UPDATE
"MATERIALIZATION_REBUILD_LOCKS" SET "MRL_LAST_HEARTBEAT" = 17125719195
46 matches
Mail list logo
