Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1589937210 ## ql/src/test/queries/clientnegative/load_data_partition.q: ## @@ -0,0 +1,7 @@ +--load data if the file does not exist + +CREATE TABLE validate_load_data(key int,

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2093630517 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2092727239 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1588090924 ## ql/src/test/queries/clientnegative/load_data_partition.q: ## @@ -0,0 +1,7 @@ +--load data if the file does not exist + +CREATE TABLE validate_load_data(key int,

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2084367398 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2083711642 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2082615712 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1578076516 ## ql/src/test/results/clientnegative/load_wrong_noof_part.q.out: ## @@ -6,4 +6,4 @@ POSTHOOK: query: CREATE TABLE loadpart1(a STRING, b STRING) PARTITIONED BY (ds S

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2074919852 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2074262864 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1577238980 ## ql/src/test/results/clientnegative/load_wrong_noof_part.q.out: ## @@ -6,4 +6,4 @@ POSTHOOK: query: CREATE TABLE loadpart1(a STRING, b STRING) PARTITIONED BY

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1576424351 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1575895273 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1568283994 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI fromURI, Table table) t

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2051284224 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2046643880 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1558845820 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI fromURI, Table table) t

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

deniskuzZ commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI fromURI, Table table) t

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

deniskuzZ commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI fromURI, Table table) t

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

deniskuzZ commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI fromURI, Table table) t

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

deniskuzZ commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1557452129 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -325,6 +337,8 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

deniskuzZ commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1557448538 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -181,7 +184,16 @@ private List applyConstraintsAndGetFiles(URI fromURI, Table table) t

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1547102223 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1547115174 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java: ## @@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception { */ @Test public

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1547102223 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1546692298 ## ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java: ## @@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws SemanticException {

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1546686701 ## ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java: ## @@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception { */ @Test

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1968253683 This scenario will fail before fixing this issue at job execution and now it is validated at Hiveserver and it will throw SemanticExceptoin to the client. What is the exception

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1943585524 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1943126065 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

chinnaraolalam commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1487125020 ## itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java: ## @@ -3422,4 +3422,26 @@ public void testHeaderFooterNonTextFiles() throws Exception

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1924993607 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1924055005 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1923268567 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1922485979 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1920553543 There is a test failure in Jenkins, i ran the test in in local and that test is passing which can be viewed in the below screenshot:

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

shivjha30 commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1920534391 @ayushtkn Thanks for the review, i have added the test case as mentioned above.please review once -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-1887705670 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate