[GitHub] [hive] pkumarsinha commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…

2021-05-12 Thread GitBox
pkumarsinha commented on a change in pull request #2135: URL: https://github.com/apache/hive/pull/2135#discussion_r630477224 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java ## @@ -33,6 +33,7 @@ private String dumpDir;

[GitHub] [hive] kasakrisz merged pull request #2257: HIVE-25066: Show whether a materialized view supports incremental review or not

2021-05-12 Thread GitBox
kasakrisz merged pull request #2257: URL: https://github.com/apache/hive/pull/2257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] kasakrisz commented on a change in pull request #2263: HIVE-25105: Support Parquet as MV storage format

2021-05-12 Thread GitBox
kasakrisz commented on a change in pull request #2263: URL: https://github.com/apache/hive/pull/2263#discussion_r630756812 ## File path: ql/src/test/queries/clientpositive/materialized_view_parquet.q ## @@ -0,0 +1,196 @@ +-- SORT_QUERY_RESULTS + +set

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630926018 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] ayushtkn commented on a change in pull request #2249: HIVE-25092. Add a shell script to fetch the statistics of replication data copy tasks.

2021-05-12 Thread GitBox
ayushtkn commented on a change in pull request #2249: URL: https://github.com/apache/hive/pull/2249#discussion_r630936177 ## File path: bin/replstats.sh ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

[GitHub] [hive] kgyrtkirk merged pull request #2207: HIVE-25044: Parallel edge fixer may not be able to process semijoin edges

2021-05-12 Thread GitBox
kgyrtkirk merged pull request #2207: URL: https://github.com/apache/hive/pull/2207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630909854 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630909697 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630915112 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] kasakrisz opened a new pull request #2264: [draft] HIVE-24991: Enable fetching deleted rows in vectorized mode

2021-05-12 Thread GitBox
kasakrisz opened a new pull request #2264: URL: https://github.com/apache/hive/pull/2264 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630910187 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] ayushtkn commented on pull request #2249: HIVE-25092. Add a shell script to fetch the statistics of replication data copy tasks.

2021-05-12 Thread GitBox
ayushtkn commented on pull request #2249: URL: https://github.com/apache/hive/pull/2249#issuecomment-839679560 Sample Output with Path Optional: ![image](https://user-images.githubusercontent.com/25608848/117964431-39dc9100-b33f-11eb-8927-6fab55831c7e.png) Sample Output with Path

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630918129 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergQueryLifeTimeHook.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] [hive] marton-bod commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
marton-bod commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r630909697 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] lcspinter commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
lcspinter commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r631063506 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] lcspinter commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
lcspinter commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r631063850 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] lcspinter commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
lcspinter commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r631064410 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergQueryLifeTimeHook.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631128300 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java ## @@ -806,6 +806,12 @@ public void put(Writable

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631139021 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java ## @@ -54,11 +61,73 @@ private

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631157229 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java ## @@ -141,35 +280,64 @@ public void

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631163313 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java ## @@ -141,35 +280,64 @@ public void

[GitHub] [hive] lcspinter commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

2021-05-12 Thread GitBox
lcspinter commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r631066543 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +333,40 @@ private static String

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631163313 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java ## @@ -141,35 +280,64 @@ public void

[GitHub] [hive] jcamachor commented on a change in pull request #2263: HIVE-25105: Support Parquet as MV storage format

2021-05-12 Thread GitBox
jcamachor commented on a change in pull request #2263: URL: https://github.com/apache/hive/pull/2263#discussion_r631173175 ## File path: ql/src/test/queries/clientpositive/materialized_view_parquet.q ## @@ -0,0 +1,196 @@ +-- SORT_QUERY_RESULTS + +set

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631127066 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java ## @@ -499,6 +500,13 @@ public void put(Writable

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631130583 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerDirectAccess.java ## @@ -21,11 +21,15 @@ import

[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

2021-05-12 Thread GitBox
pgaref commented on a change in pull request #2004: URL: https://github.com/apache/hive/pull/2004#discussion_r631202108 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableWrapper.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to

[GitHub] [hive] lcspinter merged pull request #2258: HIVE-25100: Use default values of Iceberg client pool configuration

2021-05-12 Thread GitBox
lcspinter merged pull request #2258: URL: https://github.com/apache/hive/pull/2258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] lcspinter merged pull request #2260: HIVE-25106: Do not exclude avatica and protobuf for Iceberg

2021-05-12 Thread GitBox
lcspinter merged pull request #2260: URL: https://github.com/apache/hive/pull/2260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] dengzhhu653 closed pull request #1998: HIVE-24802: Show operation log at webui

2021-05-12 Thread GitBox
dengzhhu653 closed pull request #1998: URL: https://github.com/apache/hive/pull/1998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] belugabehr opened a new pull request #2265: HIVE-25108: Do Not Log and Throw MetaExceptions

2021-05-12 Thread GitBox
belugabehr opened a new pull request #2265: URL: https://github.com/apache/hive/pull/2265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] sunchao commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x

2021-05-12 Thread GitBox
sunchao commented on pull request #2080: URL: https://github.com/apache/hive/pull/2080#issuecomment-840028939 cc @szehon-ho could you help to review this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the