marton-bod commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r630926018
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -284,4 +333,40 @@ private static String getCatalogType(Configuration conf,
String catalogName) {
}
}
}
+
+ public static class TableCache {
+ private static final Cache<String, Table> tableCache =
Caffeine.newBuilder()
+ .expireAfterAccess(12, TimeUnit.HOURS).build();
Review comment:
Shall we decrease this a bit? Perhaps 30 minutes would also suffice? Not
sure what a "long" compilation time means for Hive usually. Decreasing it could
give us some extra safety against cache pollution in case the hook-based
eviction doesn't always go smoothly. Worst case in a very long compilation
scenario, we might reload the table again eventually, but I'm assuming
compilations that take 30+ minutes should be pretty rare?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
