okumin closed pull request #5059: Don't review
URL: https://github.com/apache/hive/pull/5059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tarak271 commented on PR #4859:
URL: https://github.com/apache/hive/pull/4859#issuecomment-1931498322
@zabetak resolved merge conflicts. Please help review and let me know if any
changes are required
--
This is an automated message from the Apache Git Service.
To respond to the message,
tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1481079675
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void run()
sonarcloud[bot] commented on PR #5014:
URL: https://github.com/apache/hive/pull/5014#issuecomment-1931721617
## [
sonarcloud[bot] commented on PR #5071:
URL: https://github.com/apache/hive/pull/5071#issuecomment-1931635425
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
deniskuzZ commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481266338
##
iceberg/iceberg-handler/src/test/queries/positive/iceberg_branch_with_different_case.q:
##
@@ -0,0 +1,57 @@
+-- SORT_QUERY_RESULTS
Review Comment:
i think it's
mlorek closed pull request #5050: HIVE-28046: Using serdeConstants fields
instead of string literals for 'columns' and 'columns.types'
URL: https://github.com/apache/hive/pull/5050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mlorek opened a new pull request, #5072:
URL: https://github.com/apache/hive/pull/5072
Using serdeConstants fields instead of string literals in hive-exec module
Why are the changes needed?
to improve the use of existing constants
Does this PR introduce any user-facing
ayushtkn commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481370671
##
iceberg/iceberg-handler/src/test/queries/positive/iceberg_branch_with_different_case.q:
##
@@ -0,0 +1,57 @@
+-- SORT_QUERY_RESULTS
Review Comment:
Changed.
--
zratkai commented on PR #5014:
URL: https://github.com/apache/hive/pull/5014#issuecomment-1932119752
@okumin @simhadri-g could you please review? Refactored to use ZoneId
instead of TimeZone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
deniskuzZ commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481266338
##
iceberg/iceberg-handler/src/test/queries/positive/iceberg_branch_with_different_case.q:
##
@@ -0,0 +1,57 @@
+-- SORT_QUERY_RESULTS
Review Comment:
i think it's
sonarcloud[bot] commented on PR #4913:
URL: https://github.com/apache/hive/pull/4913#issuecomment-1931835625
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
ayushtkn commented on PR #5071:
URL: https://github.com/apache/hive/pull/5071#issuecomment-1932006192
https://github.com/apache/hive/assets/25608848/b27ce34e-119c-48a5-8a0e-4e1a3d7abcb4;>
the title says "Upgrade Bouncy castle", how is this a "No"?, there are some
steps mentioned in
sonarcloud[bot] commented on PR #5072:
URL: https://github.com/apache/hive/pull/5072#issuecomment-1932023089
## [ {
Matcher ref =
deniskuzZ commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481593033
##
iceberg/iceberg-handler/src/test/queries/positive/write_iceberg_branch.q:
##
@@ -1,60 +0,0 @@
--- SORT_QUERY_RESULTS
Review Comment:
why did you drop this q
deniskuzZ commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481593912
##
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##
@@ -1137,7 +1137,7 @@ private String processTable(QB qb, ASTNode tabref) throws
deniskuzZ commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481627396
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##
@@ -468,4 +468,12 @@ public static Boolean isTableTag(String refName) {
Matcher ref =
deniskuzZ commented on code in PR #5038:
URL: https://github.com/apache/hive/pull/5038#discussion_r148159
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##
@@ -5094,26 +5094,22 @@ public static String
deniskuzZ commented on code in PR #5038:
URL: https://github.com/apache/hive/pull/5038#discussion_r148159
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##
@@ -5094,26 +5094,22 @@ public static String
sonarcloud[bot] commented on PR #5073:
URL: https://github.com/apache/hive/pull/5073#issuecomment-1932391575
## [
--
This is an automated
deniskuzZ commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481616732
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##
@@ -468,4 +468,12 @@ public static Boolean isTableTag(String refName) {
Matcher ref =
ayushtkn commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481671501
##
iceberg/iceberg-handler/src/test/queries/positive/write_iceberg_branch.q:
##
@@ -1,60 +0,0 @@
--- SORT_QUERY_RESULTS
Review Comment:
accidently removed the wrong
deniskuzZ commented on code in PR #5038:
URL: https://github.com/apache/hive/pull/5038#discussion_r1481700833
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##
@@ -5094,26 +5094,22 @@ public static String
mlorek commented on PR #5072:
URL: https://github.com/apache/hive/pull/5072#issuecomment-1932715287
@abstractdog can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sonarcloud[bot] commented on PR #5024:
URL: https://github.com/apache/hive/pull/5024#issuecomment-1932767721
## [ throws
ayushtkn commented on code in PR #5068:
URL: https://github.com/apache/hive/pull/5068#discussion_r1481372311
##
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##
@@ -1137,7 +1137,7 @@ private String processTable(QB qb, ASTNode tabref) throws
zabetak opened a new pull request, #5073:
URL: https://github.com/apache/hive/pull/5073
### What changes were proposed in this pull request?
Drop central and repository-release repositories from pom.xml
### Why are the changes needed?
central is implicitly inherited from Super
sonarcloud[bot] commented on PR #5074:
URL: https://github.com/apache/hive/pull/5074#issuecomment-1932829178
## [