tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1481076152
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##########
@@ -78,17 +86,13 @@ public void run() {
}
}
- private void cleanTheHouse() {
+ void cleanTheHouse() {
performTask(txnHandler::performTimeOuts, "Cleaning timed out txns and
locks");
performTask(txnHandler::performWriteSetGC, "Cleaning obsolete write set
entries");
performTask(txnHandler::cleanTxnToWriteIdTable, "Cleaning obsolete
TXN_TO_WRITE_ID entries");
- if (isCompactorEnabled) {
- performTask(txnHandler::removeDuplicateCompletedTxnComponents, "Cleaning
duplicate COMPLETED_TXN_COMPONENTS entries");
- performTask(txnHandler::purgeCompactionHistory, "Cleaning obsolete
compaction history entries");
- }
}
- private void performTask(FailableRunnable<MetaException> task, String
description) {
+ void performTask(FailableRunnable<MetaException> task, String description) {
Review Comment:
changing to protected, so that it can be accessed in sub class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
