Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2084367398 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DO-NOT-MERGE] Test 2.3 [hive]

sunchao commented on PR #5225: URL: https://github.com/apache/hive/pull/5225#issuecomment-2084435500 OK, let me merge the other PR first, and see how the post commit CI performs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2083711642 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DO-NOT-MERGE] Test 2.3 [hive]

sunchao commented on PR #5225: URL: https://github.com/apache/hive/pull/5225#issuecomment-2084423435 Interesting. This PR https://github.com/apache/hive/pull/4892 was the latest commit in branch-2.3 (well except the "Prepare for 2.3.10 release" I created), and it only has 27 test failures.

Re: [PR] Open Hive ACID txn only for transactional resources [hive]

sonarcloud[bot] commented on PR #5216: URL: https://github.com/apache/hive/pull/5216#issuecomment-2083838619 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]

pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2084405831 @sunchao the failed tests are not caused by this patch, I opened another dummy PR based on the latest branch-2.3, and got the same failures https://github.com/apache/hive/pull/5225 --

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

sonarcloud[bot] commented on PR #5222: URL: https://github.com/apache/hive/pull/5222#issuecomment-2084424227 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DO-NOT-MERGE] Test 2.3 [hive]

pan3793 commented on PR #5225: URL: https://github.com/apache/hive/pull/5225#issuecomment-2084424046 I suspect it may be caused by changes outside of the Hive code itself ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [DO-NOT-MERGE] Test 2.3 [hive]

pan3793 opened a new pull request, #5225: URL: https://github.com/apache/hive/pull/5225 Test CI stability for branch-2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HIVE-28228: Remove redundant/unused sources maven profile [hive]

ayushtkn commented on PR #5224: URL: https://github.com/apache/hive/pull/5224#issuecomment-2084364492 there is a use case mentioned:

Re: [PR] HIVE-28197: Add deserializer to convert JSON plans to RelNodes [hive]

sonarcloud[bot] commented on PR #5131: URL: https://github.com/apache/hive/pull/5131#issuecomment-2083758921 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]

sunchao merged PR #5204: URL: https://github.com/apache/hive/pull/5204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]

sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2084436105 Merged, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

sonarcloud[bot] commented on PR #5215: URL: https://github.com/apache/hive/pull/5215#issuecomment-2084313552 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]

sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2084420623 oops, thanks @pan3793 - let me check the commits in branch-2.3 and see which commit caused the regression -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Iceberg: Retrieve row count from iceberg SnapshotSummary in case of iceberg.hive.keep.stats=false [hive]

sonarcloud[bot] commented on PR #5215: URL: https://github.com/apache/hive/pull/5215#issuecomment-2081981634 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28227: Change the description of HIVE_OPTIMIZE_METADATA_DELETE config [hive]

sonarcloud[bot] commented on PR #5221: URL: https://github.com/apache/hive/pull/5221#issuecomment-2082037852 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

sonarcloud[bot] commented on PR #5222: URL: https://github.com/apache/hive/pull/5222#issuecomment-2082136168 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]

wecharyu opened a new pull request, #5223: URL: https://github.com/apache/hive/pull/5223 ### What changes were proposed in this pull request? In thrift api definition, HMS support to drop partitions by both partition names and expressions. But current api in `IMetaStoreClient` only

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

wecharyu commented on code in PR #5198: URL: https://github.com/apache/hive/pull/5198#discussion_r1582800399 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -7223,13 +7214,23 @@ private List

Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]

sonarcloud[bot] commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2082407335 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28161: Incorrect Copyright years in META-INF/NOTICE files [hive]

zabetak commented on PR #5169: URL: https://github.com/apache/hive/pull/5169#issuecomment-2082568662 @dengzhhu653 You are right, we should also add it in storage-api module. I took care of it in https://github.com/apache/hive/pull/5169/commits/8b0469c4a8859f0fff224a5fd3444a011b152964

Re: [PR] HIVE-28161: Incorrect Copyright years in META-INF/NOTICE files [hive]

sonarcloud[bot] commented on PR #5169: URL: https://github.com/apache/hive/pull/5169#issuecomment-2082814776 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

sonarcloud[bot] commented on PR #5222: URL: https://github.com/apache/hive/pull/5222#issuecomment-2083006544 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-24167: TPC-DS query 14 fails while generating plan for the filter [hive]

okumin commented on code in PR #5077: URL: https://github.com/apache/hive/pull/5077#discussion_r1583240220 ## ql/src/test/queries/clientpositive/cbo_cte_materialization.q: ## @@ -0,0 +1,28 @@ +--! qt:dataset:src + +set hive.optimize.cte.materialize.threshold=1; +set

Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]

deniskuzZ merged PR #5191: URL: https://github.com/apache/hive/pull/5191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28228: Remove redundant/unused sources maven profile [hive]

sonarcloud[bot] commented on PR #5224: URL: https://github.com/apache/hive/pull/5224#issuecomment-2082991771 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

wecharyu commented on code in PR #5198: URL: https://github.com/apache/hive/pull/5198#discussion_r1582852286 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -7350,6 +7346,25 @@ public PartitionsByExprResult

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

wecharyu commented on code in PR #5198: URL: https://github.com/apache/hive/pull/5198#discussion_r1582853401 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1046,6 +1030,20 @@ private List

Re: [PR] HIVE-27791 Eliminate totalSize check from test [hive]

zhangbutao commented on PR #4913: URL: https://github.com/apache/hive/pull/4913#issuecomment-2082607867 Any further fixs & coments here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] HIVE-28228: Remove redundant/unused sources maven profile [hive]

zabetak opened a new pull request, #5224: URL: https://github.com/apache/hive/pull/5224 ### Why are the changes needed? Simplify build and reduce maintenance overhead The sources maven profile was introduced in HIVE-5717 among others to package source code into a .jar and publish

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

sonarcloud[bot] commented on PR #5000: URL: https://github.com/apache/hive/pull/5000#issuecomment-2082615712 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

wecharyu commented on code in PR #5198: URL: https://github.com/apache/hive/pull/5198#discussion_r1582864498 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java: ## @@ -855,6 +868,20 @@ boolean getPartitionsByExpr(String

Re: [PR] HIVE-27791 Eliminate totalSize check from test [hive]

zratkai commented on PR #4913: URL: https://github.com/apache/hive/pull/4913#issuecomment-2082659491 @zhangbutao I am on it, the test env were instable, and spent a lot of time on it, to rerun, and fix some issue, but still not green. -- This is an automated message from the Apache Git

Re: [PR] HIVE-28024: Support sources profile for hive metastore modules [hive]

wecharyu closed pull request #5032: HIVE-28024: Support sources profile for hive metastore modules URL: https://github.com/apache/hive/pull/5032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

wecharyu commented on code in PR #5198: URL: https://github.com/apache/hive/pull/5198#discussion_r1583373805 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java: ## @@ -160,7 +160,7 @@ public void

Re: [PR] WIP: Dont review [hive]

sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2083235762 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

wecharyu commented on code in PR #5198: URL: https://github.com/apache/hive/pull/5198#discussion_r1583342090 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java: ## @@ -868,19 +895,6 @@ boolean getPartitionsByExpr(String

Re: [PR] HIVE-28224: Upgrade Orc version in Hive to 1.9.3 [hive]

sonarcloud[bot] commented on PR #5218: URL: https://github.com/apache/hive/pull/5218#issuecomment-2083433079 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-26926: SHOW PARTITIONS for a non partitioned table should just throw execution error instead of full stack trace. [hive]

deniskuzZ commented on PR #5164: URL: https://github.com/apache/hive/pull/5164#issuecomment-2083484044 btw, I think it's better to change the relevant `ShowPartitionsOperation` execute method instead of base one: context.getTask().setException( new

Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]

sonarcloud[bot] commented on PR #5198: URL: https://github.com/apache/hive/pull/5198#issuecomment-2083576746 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate