Re: [PR] [WIP] Calcite upgrade 1.33 [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2094083854 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables [hive]

2024-05-04 Thread via GitHub
shivjha30 commented on code in PR #5000: URL: https://github.com/apache/hive/pull/5000#discussion_r1589937210 ## ql/src/test/queries/clientnegative/load_data_partition.q: ## @@ -0,0 +1,7 @@ +--load data if the file does not exist + +CREATE TABLE validate_load_data(key int, value

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

2024-05-04 Thread via GitHub
zhangbutao commented on code in PR #5222: URL: https://github.com/apache/hive/pull/5222#discussion_r1590001048 ## iceberg/patched-iceberg-core/src/main/java/org/apache/iceberg/hadoop/HadoopInputFile.java: ## @@ -214,6 +214,10 @@ public FileStatus getStat() { return lazyStat

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

2024-05-04 Thread via GitHub
zhangbutao commented on code in PR #5222: URL: https://github.com/apache/hive/pull/5222#discussion_r1590004306 ## ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java: ## @@ -248,7 +248,9 @@ public HivePrivilegeObjectType getObjectT

Re: [PR] HIVE-28191. Upgrade Hadoop Version to 3.4.0. [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5187: URL: https://github.com/apache/hive/pull/5187#issuecomment-2094261117 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5222: URL: https://github.com/apache/hive/pull/5222#issuecomment-2094296334 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] [WIP] Calcite upgrade 1.33 [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2094476927 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] [WIP] Calcite upgrade 1.33 [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2094564820 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

[PR] [hotfix][test] Initializing MiniDFSCluster avoid using deprecated methods. [hive]

2024-05-04 Thread via GitHub
slfan1989 opened a new pull request, #5236: URL: https://github.com/apache/hive/pull/5236 ### What changes were proposed in this pull request? I have been recently tracking the issue of upgrading Hadoop from 3.3.6 to 3.4.0. During this process, I identified an improvement poin

Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]

2024-05-04 Thread via GitHub
pan3793 commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2094575223 @sunchao can we have the next RC for 2.3.10? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] HIVE-28191. Upgrade Hadoop Version to 3.4.0. [hive]

2024-05-04 Thread via GitHub
slfan1989 commented on PR #5187: URL: https://github.com/apache/hive/pull/5187#issuecomment-2094583440 I have a question. I'm trying to run unit tests locally, but I keep encountering errors like `Module 'hive-standalone-metastore-common' production: java.lang.OutOfMemoryError: GC overhead

Re: [PR] [hotfix][test] Initializing MiniDFSCluster avoid using deprecated methods. [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5236: URL: https://github.com/apache/hive/pull/5236#issuecomment-2094634940 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

[PR] HIVE-28245. Upgrade Spring to 5.3.27 due to CVE. [hive]

2024-05-04 Thread via GitHub
slfan1989 opened a new pull request, #5237: URL: https://github.com/apache/hive/pull/5237 ### What changes were proposed in this pull request? JIRA: HIVE-28245. Upgrade Spring to 5.3.27 due to CVE. I found that there are 2 CVE issues in the current Spring version, CVE-2

Re: [PR] HIVE-28121. (2.3) Use direct SQL for transactional altering table parameter [hive]

2024-05-04 Thread via GitHub
sunchao commented on PR #5204: URL: https://github.com/apache/hive/pull/5204#issuecomment-2094642723 Sorry for the delay @pan3793 . I just sent out RC1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HIVE-28132: Iceberg: Add support for Replace Tag. [hive]

2024-05-04 Thread via GitHub
ayushtkn commented on code in PR #5222: URL: https://github.com/apache/hive/pull/5222#discussion_r1590216138 ## ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java: ## @@ -248,7 +248,9 @@ public HivePrivilegeObjectType getObjectTyp

Re: [PR] HIVE-28245. Upgrade Spring to 5.3.27 due to CVE. [hive]

2024-05-04 Thread via GitHub
sonarcloud[bot] commented on PR #5237: URL: https://github.com/apache/hive/pull/5237#issuecomment-2094652541 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.