[GitHub] [hive] davidov541 commented on issue #635: HIVE-14888: Fixing the check of current security mode for Spark

davidov541 commented on issue #635: HIVE-14888: Fixing the check of current security mode for Spark URL: https://github.com/apache/hive/pull/635#issuecomment-497911329 ReviewBoard: https://reviews.apache.org/r/70718/ JIRA: https://issues.apache.org/jira/browse/HIVE-14888

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582541 ## File path: ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out ## @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582664 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ## @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582787 ## File path: ql/src/test/results/clientpositive/perf/spark/query80.q.out ## @@ -782,7 +782,7 @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582808 ## File path: ql/src/test/results/clientpositive/perf/spark/query80.q.out ## @@ -782,7 +782,7 @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582682 ## File path: ql/src/test/results/clientpositive/perf/spark/query77.q.out ## @@ -826,7 +826,7 @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582586 ## File path: ql/src/test/results/clientpositive/llap/subquery_select.q.out ## @@ -3943,10

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582362 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ## @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582883 ## File path: ql/src/test/results/clientpositive/vectorized_case.q.out ## @@ -705,13 +705,13 @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582420 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ## @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582845 ## File path: ql/src/test/results/clientpositive/spark/vectorized_case.q.out ## @@ -688,13

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582463 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ## @@

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582305 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java

[GitHub] [hive] t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting

t3rmin4t0r commented on a change in pull request #656: HIVE-21742 : Vectorization: CASE result type casting URL: https://github.com/apache/hive/pull/656#discussion_r289582521 ## File path: ql/src/test/results/clientpositive/infer_join_preds.q.out ## @@ -1187,7 +1187,7 @@

[GitHub] [hive] prasanthj commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication.

prasanthj commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication. URL: https://github.com/apache/hive/pull/648#discussion_r289528707 ## File path:

[GitHub] [hive] odraese commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication.

odraese commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication. URL: https://github.com/apache/hive/pull/648#discussion_r289455397 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

[GitHub] [hive] odraese commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication.

odraese commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication. URL: https://github.com/apache/hive/pull/648#discussion_r289455198 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

[GitHub] [hive] odraese commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication.

odraese commented on a change in pull request #648: HIVE-21783: Accept Hive connections from the same domain without authentication. URL: https://github.com/apache/hive/pull/648#discussion_r289455006 ## File path: service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java

[GitHub] [hive] odraese commented on issue #643: Hive 21785: Add task queue/runtime stats per LLAP daemon to output

odraese commented on issue #643: Hive 21785: Add task queue/runtime stats per LLAP daemon to output URL: https://github.com/apache/hive/pull/643#issuecomment-497766195 Added updated version as patch to https://issues.apache.org/jira/browse/HIVE-21785

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289320836 ## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java ##

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289320836 ## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java ##

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289317467 ## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java ##

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289292223 ## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289290466 ## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java ##

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289284589 ## File path: llap-common/src/test/org/apache/hadoop/hive/llap/metrics/MockMetricsCollector.java ## @@

[GitHub] [hive] sankarh opened a new pull request #655: HIVE-21811: Load data into partitioned table throws NPE if DB is enabled for replication.

sankarh opened a new pull request #655: HIVE-21811: Load data into partitioned table throws NPE if DB is enabled for replication. URL: https://github.com/apache/hive/pull/655 This is an automated message from the Apache Git

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289282673 ## File path: hive-site.xml ## @@ -0,0 +1,358 @@ + Review comment: Added by mistake. Removed.

[GitHub] [hive] pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics

pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP execution latency metrics URL: https://github.com/apache/hive/pull/633#discussion_r289282184 ## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java