pvary commented on a change in pull request #633: HIVE-21740: Collect LLAP
execution latency metrics
URL: https://github.com/apache/hive/pull/633#discussion_r289317467
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -1175,6 +1178,9 @@ public boolean deallocateTask(
LOG.debug("Processing deallocateTask for task={}, taskSucceeded={},
endReason={}", task,
taskSucceeded, endReason);
}
+ if (task instanceof TaskAttemptImpl && metrics != null) {
+ updateMetrics((TaskAttemptImpl)task);
Review comment:
The metrics can be null in case of
conf.getBoolean(ConfVars.HIVE_IN_TEST.varname, false)
I tried to find the style problem, but not sure which part should be written
differently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
