franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521563027
Yes, sure and will provide proper yes and coverage too as it deserves :)
Thanks for the suggestions Michael
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521559226
I understand your comment now, my comment was related to the code itself,not
the feature as a whole: I see th
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521557724
The feature of shared store colocated is not totally broken, but the shared
store colocation using group name
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556443
The version proposal is probably the best solution indeed: the reason why
the old logic breaks the new one is
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521550401
@michaelandrepearce Agree, but nonetheless my comment on the code hold:
```
// Older versions of artemis
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520889867
@howardgao @jbertram wdyt?
This is an automa
franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared
store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520888383
This PR is adding `BackupRequestMessage`'s `nodeID` information for shared
store colocated setup, to enable p
